Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/documentation cleanup #228

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Feature/documentation cleanup #228

merged 4 commits into from
Feb 27, 2024

Conversation

Laguna1989
Copy link
Collaborator

This PR was done pairing in support for catch2 v3

@claremacrae claremacrae merged commit cb508f1 into approvals:master Feb 27, 2024
2 of 4 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: This PR introduces updates to the documentation and build notes to reflect the support for Catch2v2 and the integration of CPM as a package manager for handling dependencies. It includes changes to the CMake integration guide to accommodate the new version of Catch2 and introduces CPM for more efficient dependency management. The changes aim to improve the project's build process by offering more options for dependency management and ensuring compatibility with the latest version of Catch2.

Decision: Comment

📝 Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all instances where Catch2 is mentioned are updated to reflect the move to Catch2v2 to maintain consistency across the documentation.
  • Consider adding a brief section on migrating from Catch2 to Catch2v2 for users who might be directly affected by this change.
  • It might be beneficial to include examples or more detailed instructions on how to use CPM for dependency management, especially for users who are not familiar with it.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants