Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add genkai-point-formula v3 #82

Merged
merged 16 commits into from
Jan 5, 2024
Merged

feat: add genkai-point-formula v3 #82

merged 16 commits into from
Jan 5, 2024

Conversation

nanai10a
Copy link
Member

close #79

@nanai10a nanai10a added the enhancement New feature or request label Dec 29, 2023
@nanai10a nanai10a requested a review from kawaemon December 29, 2023 20:14
@nanai10a nanai10a self-assigned this Dec 29, 2023
@nanai10a
Copy link
Member Author

@kawaemon 本番のデータを使って試運転したいんですが, 可能ですか? (本番環境で動かしたいという意味では決してありません)

@kawaemon
Copy link
Member

@nanai10a
来年頭になりますがデータ用意します!

@nanai10a
Copy link
Member Author

nanai10a commented Jan 4, 2024

試しに bigdecimal に置き換えてみましたが, 計算にエグい時間掛かるので… 計算資源が有り余りすぎて暇な CPU がゴロゴロ転がっている際にのみご利用いただけます. patch は ff94f56 にあるので, もしもご所望ならご利用いただけます.

@nanai10a
Copy link
Member Author

nanai10a commented Jan 4, 2024

という訳で v3 の計算を大人しく f64 で実行するように revert を打ち clippy の怒りを沈めたところで RfR です. @kawaemon がやれと言ったのでやりましたが, この PR は out-of-scope な破壊的変更を含んでいます. よろしくお願いします.

@nanai10a nanai10a marked this pull request as ready for review January 4, 2024 21:14
@kawaemon kawaemon added this pull request to the merge queue Jan 5, 2024
@kawaemon
Copy link
Member

kawaemon commented Jan 5, 2024

お疲れ様でした!

Merged via the queue into master with commit 7cc2abc Jan 5, 2024
3 checks passed
@nanai10a nanai10a deleted the add-formula-v3 branch June 18, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

限界ポイント Formula v3 の実装
2 participants