Security Patch - BLACK-1545 #1104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlandia
suggested changes
Mar 18, 2022
There was a problem hiding this comment.
Thanks @shadinaif !
Looks like this one addresses all of one patch but not another. Please see Jira ticket for rest of response, as this is a public repo.
if user password is unusable then disable third party login LEARNER-6183
Could not implement authentication.py part since it is outdated See details in JIRA
bryanlandia
reviewed
Mar 26, 2022
There was a problem hiding this comment.
Thanks @shadinaif ! Sorry this part was such a pain. It look good, I'm just going to try running this branch in a Hawthorn devstack and run tests.... unless you have.
|
Any update on this? |
|
@shadinaif I was wondering if you had already run tests on this in a Hawthornd devstack branch. Let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
For Hawthorn Master: Security Patch - BLACK-1545.
Type of change
Related issues
https://appsembler.atlassian.net/browse/BLACK-1545
https://appsembler.atlassian.net/browse/RED-2867
Checklists
Development
Security
Code review