Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tahoe-idp 2.4.0 #1346

Closed
wants to merge 1 commit into from

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Jun 22, 2023

Change description

Adds feature to sync configured user fields (default first, last, full names) back to IdP on User and UserProfile post_save. Signal handlers configured via plugin arch

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-125

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Adds feature to sync configured user fields (default first, last, full names) back to IdP
on User and UserProfile post_save.  Signal handlers configured via plugin arch
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 298
Current conflicts 298
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 315
Current conflicts 315
Summary Good work! No added conflicts.

@bryanlandia bryanlandia marked this pull request as draft June 22, 2023 20:06
@bryanlandia
Copy link
Author

Back to draft... haven't actually released 2.4.0 to PyPI yet :D

@bryanlandia bryanlandia marked this pull request as ready for review June 22, 2023 20:09
@bryanlandia
Copy link
Author

bryanlandia commented Jun 22, 2023

Putting back ready to review, just expect the Build test will fail until 2.4.0 is cut
See appsembler/tahoe-idp#87

If anything else fails I won't merge and will reopen the PR with fixes

@bryanlandia
Copy link
Author

Closed in favor of #1348

@bryanlandia
Copy link
Author

Closing to use 2.4.3

auto-merge was automatically disabled June 28, 2023 19:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants