Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tahoe-idp 2.4.3 #1349

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Use tahoe-idp 2.4.3 #1349

merged 3 commits into from
Jun 28, 2023

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Jun 28, 2023

Change description

Use tahoe-idp 2.4.3, which adds signal receiver on User and UserProfile to sync name fields to IdP
Bug and test fixes since 2.4.0.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-125

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Syncs first, last, full names back to IdP
It relies on configuration that we don't set up in test
@bryanlandia bryanlandia changed the title Use tahoe idp 2.4.3 Use tahoe-idp 2.4.3 Jun 28, 2023
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 298
Current conflicts 298
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 315
Current conflicts 315
Summary Good work! No added conflicts.

Copy link

@amirtds amirtds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanlandia bryanlandia merged commit e5779cc into main Jun 28, 2023
11 checks passed
@bryanlandia bryanlandia deleted the bugfix/use-tahoe-idp-2.4.3 branch June 28, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants