Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain for video block LMS Root used for YT metadata #1356

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Jul 6, 2023

Change description

In video_module, get customer domain (including custom domain override) for the LMS root URL used as the prefix for requests to the block handler that retrieves metadata from YouTube. It's been using tahoe.appsembler.com, which results in a 302 to login, then a CORS error from the handler.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions

This comment has been minimized.

@appsembler appsembler deleted a comment from github-actions bot Jul 6, 2023
@appsembler appsembler deleted a comment from github-actions bot Jul 6, 2023
@bryanlandia bryanlandia force-pushed the bugfix/video-block-yt-metadata-multitenant-url branch from 064194e to e2e2f4e Compare July 6, 2023 19:45
@appsembler appsembler deleted a comment from github-actions bot Jul 6, 2023
@bryanlandia bryanlandia marked this pull request as ready for review July 6, 2023 19:47
@bryanlandia bryanlandia changed the title WIP Fix domain for video block LMS Root used for YT metadata Fix domain for video block LMS Root used for YT metadata Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 298
Current conflicts 299
Summary Adds 1 new conflicts. How can we do better?
New conflicting files with 'open-release/nutmeg.master'
common/lib/xmodule/xmodule/video_module/video_module.py
Comparing with master
Benchmark conflicts with main 313
Current conflicts 315
Summary Adds 2 new conflicts. How can we do better?
New conflicting files with 'master'
xmodule/video_block/video_block.py

@bryanlandia bryanlandia merged commit f45e0e0 into main Jul 6, 2023
11 checks passed
@bryanlandia bryanlandia deleted the bugfix/video-block-yt-metadata-multitenant-url branch July 6, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants