Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-97 Try/Catch around more of the onYouTubeIframeAPIReady code to retry #1370

Merged
merged 3 commits into from
Sep 14, 2023
Merged

ENG-97 Try/Catch around more of the onYouTubeIframeAPIReady code to retry #1370

merged 3 commits into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. wrap most of the onYouTubeIframeAPIReady function in try/catch 

    ENG-97
Try to fix continuing cases of window.onYouTubeIframeAPIReady.resolve is not a function
and retry the full function
    @bryanlandia
    bryanlandia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8a4dfa4 View commit details
    Browse the repository at this point in the history

  2. Allow up to 5 retries on onYouTubeIframeAPIReady func calls

    @bryanlandia
    bryanlandia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d5e0929 View commit details
    Browse the repository at this point in the history

  3. Add a 500ms delay before retrying onYouTubeIframeAPIReady

    @bryanlandia
    bryanlandia committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6bb24a6 View commit details
    Browse the repository at this point in the history