Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edx-sga use v0.12.0-appsembler1 (0.12.0 but local js files) #1381

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

bryanlandia
Copy link

Change description

use our fork of edx-sga 0.12.0

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-307

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/koa.master
Benchmark conflicts with appsembler/psu-temp-tahoe-juniper 105
Current conflicts 105
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with appsembler/psu-temp-tahoe-juniper 334
Current conflicts 334
Summary Good work! No added conflicts.

@bryanlandia bryanlandia merged commit 91eda07 into appsembler/psu-temp-tahoe-juniper Sep 27, 2023
3 of 9 checks passed
@bryanlandia bryanlandia deleted the psu/use-sga-0.12.0 branch September 27, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants