Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle Request objects in Segment fetch override #1382

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

amirtds
Copy link

@amirtds amirtds commented Nov 14, 2023

Change description

This change fixes the TypeError that was thrown when trying to call substr on a Request object and ensures that analytics events are correctly replicated to the appropriate Segment backends.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-334

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

This comment has been minimized.

Copy link

@bryanlandia bryanlandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good but let's test the Segment case on staging before pushing to prod

@bryanlandia bryanlandia self-requested a review November 14, 2023 21:41

This comment has been minimized.

Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 320
Current conflicts 320
Summary Good work! No added conflicts.

@amirtds amirtds merged commit ff169a3 into main Nov 14, 2023
11 checks passed
@amirtds amirtds deleted the fix/segment-fetch-interception branch November 14, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants