Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Arabic translation placeholders in progress page #1385

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

amirtds
Copy link

@amirtds amirtds commented Nov 17, 2023

Change description

When switching to the Arabic language, the progress page throws a KeyError due to incorrect translation placeholders in the Arabic translation file.
This PR corrects the placeholders in the Arabic translation for the progress page. The placeholders {username} and {email} were incorrectly translated to Arabic, causing format string errors.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 320
Current conflicts 320
Summary Good work! No added conflicts.

Copy link

@bryanlandia bryanlandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops! :D

@amirtds amirtds merged commit 28452ab into main Nov 21, 2023
11 checks passed
@amirtds amirtds deleted the fix/arabic-translation-placeholder branch November 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants