Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Mandrill Subaccount support #1396

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

amirtds
Copy link

@amirtds amirtds commented Jan 27, 2024

Change description

Adding Mandrill Subaccount support. We tried to use dedicated IP for PSU but Mandrill team told us the best way to handle large number of emails is subaccount. Back in 2021 I added the subaccount support to Hawthorn but seems it never made it to Juniper. #1035

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 318
Current conflicts 318
Summary Good work! No added conflicts.

Copy link

@bryanlandia bryanlandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amirtds amirtds merged commit 2de42bd into main Jan 29, 2024
11 checks passed
@amirtds amirtds deleted the feat/add-mandrill-subaccount-support branch January 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants