Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide html elements if the parameter is set #1411

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

VladyslavTy
Copy link

Change description

Hide elements basing on cookie value. This cookie is set if the hide_elements query parameter is set while enroll user in course.
Refactor previous solution with iframe to make it more flexible.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

Checking git merge conflicts against https://github.com/openedx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 302
Current conflicts 301
Summary Resolves 1 existing conflicts. Amazing!
Comparing with master
Benchmark conflicts with main 332
Current conflicts 331
Summary Resolves 1 existing conflicts. Amazing!

@VladyslavTy VladyslavTy merged commit 3914714 into main Aug 19, 2024
11 checks passed
@VladyslavTy VladyslavTy deleted the vladyslav/hide-html-elements-in-iframe branch August 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants