Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tox and gitbub actions: avoid getting stale css #153

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

OmarIthawi
Copy link
Contributor

@OmarIthawi OmarIthawi commented Apr 8, 2021

Changes

  • Add tox to compile SCSS files easily via tox -e compile
  • Add GitHub actions to block pull requests from unless the CSS file is compiled

Partially fixes #91

What does the error look like?

image

More details?

This what the GitHub actions shows when it fails:

Error: CSS is out of sync
=== Start: Git diff ===
diff --git a/cms/static/css/amc-specific.css b/cms/static/css/amc-specific.css
index 61c5a1e..2d4bb1d 100644
--- a/cms/static/css/amc-specific.css
+++ b/cms/static/css/amc-specific.css
@@ -99,3 +99,6 @@ body.view-settings .group-settings.basic .list-actions {
     max-width: 48rem;
     width: 80%;
     margin-bottom: 5rem; }
+
+.xblock .mentoring .copyright {
+  display: none; }
=== End: Git diff ===
Error: The CSS file is out of sync with the SCSS file.
The git diff above shows the difference.
Please use "$ tox -e compile" locally to compile the SCSS file.
ERROR: InvocationError for command /bin/bash scripts/verify.sh (exited with code 1)
____________ summary ____________
ERROR:   verify: commands failed

@OmarIthawi OmarIthawi merged commit 1685c9e into juniper/tahoe Apr 8, 2021
@OmarIthawi OmarIthawi deleted the omar/tox branch April 8, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants