Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout delay prior to GTM init to fix intermittent YouTube video module loading problems #278

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add a timeout delay prior to GTM init to fix intermittent YouTube video module loading problems #278

merged 1 commit into from
Jul 7, 2023

Conversation

bryanlandia
Copy link
Contributor

@bryanlandia bryanlandia commented Jul 7, 2023 •
edited
Loading

Change description

Address intermittent failure to load YouTube video module content Apparently only an issue when customer uses Google Analytics<4 with Measure videos turned on Following solution proposed in https://discuss.openedx.org/t/first-video-on-lesson-dont-work/3836/3B

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia
Add a timeout delay prior to GTM init
57438dc 
Address intermittent failure to load YouTube video module content
Apparently only an issue when customer uses Google Analytics<4 with Measure videos turned on
Following solution proposed in  https://discuss.openedx.org/t/first-video-on-lesson-dont-work/3836/3B
ENG-97
@bryanlandia bryanlandia marked this pull request as ready for review July 7, 2023 18:15
@bryanlandia bryanlandia requested a review from a team as a code owner July 7, 2023 18:15
@bryanlandia bryanlandia requested a review from jfaMan July 7, 2023 18:17
@bryanlandia bryanlandia merged commit e6cc775 into juniper/tahoe Jul 7, 2023
1 check failed
@bryanlandia bryanlandia deleted the bugfix/gtm-with-video-measurement-breaks-video-load branch July 7, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirtds amirtds amirtds approved these changes

@jfaMan jfaMan Awaiting requested review from jfaMan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanlandia @amirtds