Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from main (production) #279

Open
wants to merge 7 commits into
base: juniper/tahoe-prod
Choose a base branch
from

Commits on Jul 7, 2023

  1. Add a timeout delay prior to GTM init

    Address intermittent failure to load YouTube video module content
    Apparently only an issue when customer uses Google Analytics<4 with Measure videos turned on
    Following solution proposed in  https://discuss.openedx.org/t/first-video-on-lesson-dont-work/3836/3B
    ENG-97
    bryanlandia committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    57438dc View commit details
    Browse the repository at this point in the history
  2. Merge pull request #278 from appsembler/bugfix/gtm-with-video-measure…

    …ment-breaks-video-load
    
    Add a timeout delay prior to GTM init to fix intermittent YouTube video module loading problems
    bryanlandia authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e6cc775 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    f9ed07d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #280 from appsembler/bugfix/gtm-with-video-measure…

    …ment-breaks-video-load
    
    Increase timeout before gtm init to 3 seconds for yt video api compat
    bryanlandia authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    33763de View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. reorganize all GA and GTM code into body-extra

    Move out of head to avoid breaKing YouTube video/API loading
    bryanlandia committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    830a624 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37bfea1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge pull request #281 from appsembler/bugfix/gtm-with-video-measure…

    …ment-breaks-video-load
    
    Move all GA and GTM code to end of body tag
    bryanlandia authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a36ee01 View commit details
    Browse the repository at this point in the history