Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how Figures handles missing settings.ENV_VAR['FIGURES'] #456

Open
johnbaldwin opened this issue Apr 25, 2022 · 0 comments
Open

Update how Figures handles missing settings.ENV_VAR['FIGURES'] #456

johnbaldwin opened this issue Apr 25, 2022 · 0 comments

Comments

@johnbaldwin
Copy link
Contributor

@bryanlandia made a comment to not use bracket notation for settings.ENV_VAR['FIGURES']

#452 (comment)

This bracket notation is used throughout Figures and if Figures is instantiated as an Open edX plugin, it will always exist. See here: https://github.com/appsembler/figures/blob/main/figures/settings/lms_production.py#L127

So I created this card to note this topic was raised and to provide a location to discuss improving the architecture.

A couple of considerations to seed conversation:

  1. What if Figures ran as a standalone service, as a Django reusable app on a Django server that is not Open edX (edx-platform)? What should the configuration look like?
  2. How should we improve Figures Open edX plug-in settings? For example, should Figures automagically fill in defaults into settings.ENV_TOKENS['FIGURES']. Given prior conversations on Figures plugin setting defaults, IIRC @OmarIthawi was against this
  3. Perhaps we implement a module/function or class to serve as "the source of truth" for Figures settings and this module or class serves as an adapter to the Django site upon which Figures runs. Consider what this may mean for running on Open edX and the existing figures.settings.lms_production module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant