chore: Rahulbarwal/hotfix-v1.53/select-widget-handling

[rahulbarwal]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Introduced a function to process option arrays based on source data, improving option handling.
  • Enhanced validation logic for label and value keys to accommodate arrays of identical values.

• Bug Fixes

  • Improved error handling in validation functions while maintaining existing checks for invalid entries.

[coderabbitai]

Walkthrough

The pull request introduces improvements to the SelectWidget's option processing logic. A new function processOptionArray is added to handle option arrays more intelligently, particularly when dealing with source data. The changes enhance the widget's ability to process options by adding a more robust method for extracting and validating option labels and values, especially in scenarios with uniform array inputs.

Changes

File	Change Summary
app/client/.../SelectWidget/widget/derived.js	Added processOptionArray function to intelligently process option arrays
app/client/.../SelectWidget/widget/propertyUtils.ts	Enhanced labelKeyValidation and valueKeyValidation to handle arrays with identical values

Sequence Diagram

sequenceDiagram
    participant Widget as SelectWidget
    participant Util as PropertyUtils
    participant Source as SourceData
    
    Widget->>Util: Validate label/value keys
    Util->>Source: Check source data
    Util-->>Widget: Return processed options

Loading

Possibly related PRs

• fix: Enhance SelectWidget label and value handling logic #38254: Introduces similar processOptionArray function in SelectWidget
• chore: Remove empty canvas prompts and improve widget editor header #33993: Modifies validation logic for handling identical value arrays

Suggested Labels

Bug, Select Widget, ok-to-test, Widgets & Accelerators Pod

Suggested Reviewers

• ApekshaBhosale
• jsartisan
• sagar-qa007

Poem

🔍 Options dancing, data in sync,
A widget's logic, quick as a blink!
Arrays aligned, validation's art,
Select Widget's smarts set it apart!
Code refactored with surgical might 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9705048 and 4453206.

📒 Files selected for processing (2)

• app/client/src/widgets/SelectWidget/widget/derived.js (1 hunks)
• app/client/src/widgets/SelectWidget/widget/propertyUtils.ts (2 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

app/client/src/widgets/SelectWidget/widget/propertyUtils.ts

[error] 149-149: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

---

[error] 250-250: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

🔇 Additional comments (1)

app/client/src/widgets/SelectWidget/widget/derived.js (1)

45-45: LGTM: Proper implementation of processOptionArray

The function is correctly used for both label and value processing.

Also applies to: 51-51

[coderabbitai]

⚠️ Potential issue

Add null checks and safer property access

The function needs defensive programming for edge cases.

Apply these improvements:

 const processOptionArray = (optionArray, sourceData) => {
-  if (!sourceData.length) return [];
+  if (!Array.isArray(sourceData) || !sourceData.length || !sourceData[0]) return [];
 
   const allEqual = optionArray.every((item, _, arr) => item === arr[0]);
-  const keyExistsInSource = optionArray[0] in sourceData[0];
+  const keyExistsInSource = Object.hasOwn(sourceData[0], String(optionArray[0]));
 
   return allEqual && keyExistsInSource
     ? sourceData.map((d) => d[optionArray[0]])
     : optionArray;
 };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const processOptionArray = (optionArray, sourceData) => {
	if (!sourceData.length) return [];
	const allEqual = optionArray.every((item, _, arr) => item === arr[0]);
	const keyExistsInSource = optionArray[0] in sourceData[0];
	return allEqual && keyExistsInSource
	? sourceData.map((d) => d[optionArray[0]])
	: optionArray;
	};
	const processOptionArray = (optionArray, sourceData) => {
	if (!Array.isArray(sourceData) || !sourceData.length || !sourceData[0]) return [];
	const allEqual = optionArray.every((item, _, arr) => item === arr[0]);
	const keyExistsInSource = Object.hasOwn(sourceData[0], String(optionArray[0]));
	return allEqual && keyExistsInSource
	? sourceData.map((d) => d[optionArray[0]])
	: optionArray;
	};

[coderabbitai]

🛠️ Refactor suggestion

Remove duplicated validation logic

This block duplicates the logic from labelKeyValidation.

Use the suggested validateSourceDataKey helper function here as well.

🧰 Tools

🪛 Biome (1.9.4)

[error] 250-250: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

[coderabbitai]

⚠️ Potential issue

Replace hasOwnProperty with Object.hasOwn

Direct hasOwnProperty calls are unsafe.

Use Object.hasOwn() instead of the prototype method call.

Also applies to: 250-250

🧰 Tools

🪛 Biome (1.9.4)

[error] 149-149: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

[coderabbitai]

🛠️ Refactor suggestion

Refactor validation logic for better safety and reusability

The validation logic needs improvement in error handling and property access.

Consider extracting the common logic and adding safety checks:

+ const validateSourceDataKey = (value: unknown[], sourceData: unknown[]) => {
+   if (!Array.isArray(sourceData) || !sourceData.length || !sourceData[0]) {
+     return { isValid: false, parsedValue: [] };
+   }
+   
+   const areAllValuesEqual = value.every((item, _, arr) => item === arr[0]);
+   const firstValue = String(value[0]);
+   
+   if (areAllValuesEqual && Object.hasOwn(sourceData[0], firstValue)) {
+     return {
+       isValid: true,
+       parsedValue: sourceData.map((d: Record<string, unknown>) => d[firstValue]),
+     };
+   }
+   
+   return { isValid: false, parsedValue: [] };
+ };

Then use this helper in both validation functions.

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Biome (1.9.4)

[error] 149-149: Do not access Object.prototype method 'hasOwnProperty' from target object.

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

(lint/suspicious/noPrototypeBuiltins)

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions]

This PR has been closed because of inactivity.