ci: allow port for mssql-server

[sagar-qa007]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13138688065
Commit: 514fc7b
Cypress dashboard.
Tags: @tag.Datasource
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

---

Tue, 04 Feb 2025 15:26:25 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

Summary by CodeRabbit

• Chore
  • Updated the default value for the ted_tag input in the testing workflow to improve version management.
  • Enhanced network access settings in our testing workflow to improve connectivity and ensure a more stable environment during specific scenarios.
  • Enhanced Docker configuration to expose necessary ports for better communication with services.
  • Added steps to check the status of the SQL Server service and accept the EULA during setup.

[coderabbitai]

Walkthrough

The changes introduce modifications to the GitHub Actions workflow for the Appsmith CI Test. A command sudo ufw allow 1433/tcp is added to permit traffic through TCP port 1433 when the run result is not 'success'. Additionally, the Docker run command for the test-event-driver container is updated to expose port 1433 on the host. New steps for checking the mssql-server service status and accepting the SQL Server EULA are included, followed by a restart of the test-event-driver container. The overall control flow remains largely unchanged.

Changes

File(s)	Change Summary
.github/workflows/ci-test-custom-script.yml	Updated ted_tag default value to nightly; added command sudo ufw allow 1433/tcp; modified Docker run command to expose port 1433; added steps for mssql-server service status check and EULA acceptance.

Possibly related PRs

• chore: Update server log path #37839: The changes in the main PR and the retrieved PR both modify the ted_tag input parameter in the GitHub Actions workflow located in .github/workflows/ci-test-custom-script.yml, indicating a direct relationship between them.
• chore: Supress the failure in case DB url is not found in CI #36796: The changes in the main PR are related to the modifications of the ted_tag input parameter in the GitHub Actions workflow, which is also addressed in the retrieved PR where the ted_tag input is defined.
• ci: Removed port 22 from ted in ci-test #37180: The changes in the main PR and the retrieved PR both involve modifications to the docker run command for the test-event-driver service in the same workflow file, indicating a direct relationship between the two.

Suggested reviewers

• sharat87

Poem

In the pipeline where code meets the night,
A command emerges, shining so bright.
Ports open wide with a swift command,
Keeping the flow just as planned.
Cheers to progress and CI delight! 🎉

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/ci-test-custom-script.yml (2)

27-31: Default Tag Consistency:
The default for the ted_tag input is now set to nightly, which clearly indicates a preference for nightly builds over the previous latest tag. However, note that in the Docker run command (line 157) the image reference is still using the fallback ${ted_tag:-latest}. For consistency, consider removing the fallback (or updating it) to ensure that the default value is always nightly.

-            "appsmith/test-event-driver:${ted_tag:-latest}"
+            "appsmith/test-event-driver:${ted_tag}"

---

158-160: SQL Server Service Setup:
The new steps to check the status of mssql-server, accept the EULA, and restart the container are crucial for initializing SQL Server within the container environment. It might be beneficial to add error handling or checks (e.g., verifying the exit status) to ensure these commands succeed, which could help in diagnosing any startup issues during CI runs.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50e4463 and 514fc7b.

📒 Files selected for processing (1)

• .github/workflows/ci-test-custom-script.yml (3 hunks)

🔇 Additional comments (2)

.github/workflows/ci-test-custom-script.yml (2)

152-152: Firewall Rule Addition:
Adding the line sudo ufw allow 1433/tcp appropriately opens up the SQL Server port on the host. Please ensure that this change aligns with your CI security policies and does not inadvertently expose the port in an unintended environment.

---

155-157: Exposing MSSQL Port in Docker Run:
The updated Docker run command now explicitly maps port 1433 from the container to the host (-p 1433:1433), which is essential for enabling SQL Server connectivity in the CI environment. Confirm that this port mapping is free from conflicts with other services running in the CI.