perf: improve speed of SortedMap.addAll

appsup-dart · Feb 29, 2024 · d548773 · d548773
1 parent 8d75bbc
commit d548773
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/src/treemap.dart b/lib/src/treemap.dart
@@ -32,8 +32,8 @@ class TreeMap<K extends Comparable, V> extends MapBase<K, V> {
   @override
   void operator []=(K key, V value) {
     var p = MapEntry<K, V>(key, value);
-    _tree.remove(
-        p); // first remove otherwise not overwritten, could be improved?
+    // _tree.remove(
+    //     p); // first remove otherwise not overwritten, could be improved?
     _tree.add(p);
   }
 

diff --git a/lib/src/treeset.dart b/lib/src/treeset.dart
@@ -713,7 +713,14 @@ class AvlNode<V> {
   AvlNode<V> add(Comparator<V> comparator, V element) {
     var compare = comparator(element, object);
     if (compare == 0) {
-      return this;
+      if (identical(object, element)) {
+        return this;
+      }
+      return AvlNode(
+        object: element,
+        left: left,
+        right: right,
+      );
     } else if (compare < 0) {
       var newLeft = left?.add(comparator, element) ?? AvlNode(object: element);
       if (newLeft == left) return this;