2.1.3 PR feedback: throw AssertionError instead of RuntimeException

CHANGELOG.md

@@ -1,9 +1,8 @@
-# 2016-01-20 - 2.1.3
+# 2016-01-22 - 2.1.3
 
 #### Bug Fixed and Improvements
 
-*  If apps upgrading from pre-2.0.0 still has now obsolete NetworkStateReceiver defined in their manifest, an immediate run-time exception will help them detect early. 
-*  Message Center now has different layout on tablet
+*  If apps upgrading from pre-2.0.0 still has now obsolete NetworkStateReceiver defined in their manifest, an immediate run-time assertion error will help app developers detect early. 
 
 # 2016-01-08 - 2.1.2
 

apptentive/src/com/apptentive/android/sdk/Apptentive.java

@@ -83,10 +83,7 @@ public static void onStart(Activity activity) {
 			}
 			runningActivities++;
 			MessageManager.setCurrentForgroundActivity(activity);
-		} catch (RuntimeException e) {
-			throw e;
-		}
-		catch (Exception e) {
+		} catch (Exception e) {
 			Log.w("Error starting Apptentive Activity.", e);
 			MetricModule.sendError(activity.getApplicationContext(), e, null, null);
 		}
@@ -1033,9 +1030,9 @@ private static void init(Activity activity) {
 				ActivityInfo[] registered = packageInfo.receivers;
 				if (registered != null) {
 					for (ActivityInfo activityInfo : registered) {
-						// Throw immediate runtime exception when relict class found in manifest.
+						// Throw assertion error when relict class found in manifest.
 						if (activityInfo.name.equals("com.apptentive.android.sdk.comm.NetworkStateReceiver")) {
-							throw new RuntimeException("NetworkStateReceiver has been removed from Apptentive SDK, please make sure it's also removed from manifest file");
+							throw new AssertionError("NetworkStateReceiver has been removed from Apptentive SDK, please make sure it's also removed from manifest file");
 						}
 					}
 				}