Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label sales_order_id to sales_order for consistency and clarity #20

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

HappyTetrahedron
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron commented Dec 13, 2023

Summary

  • The label used for deriving the correct Sales Order is now expected as sales_order instead of sales_order_id (since the label value does not actually correspond to the ID of the sales order in Odoo, but to the name). This breaks existing queries which provide the old sales_order_id label.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@HappyTetrahedron HappyTetrahedron added enhancement New feature or request breaking labels Dec 13, 2023
@HappyTetrahedron HappyTetrahedron requested a review from a team as a code owner December 13, 2023 12:28
@HappyTetrahedron
Copy link
Contributor Author

We don't have existing queries, so this is the moment to fix the inconsistency, else it'll be too late.

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@corvus-ch corvus-ch merged commit f8eef2d into master Dec 21, 2023
3 checks passed
@corvus-ch corvus-ch deleted the feat/sales_order_rename branch December 21, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants