Don't sent empty samples to odoo #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
force-pushed
the
fix/empty_sample
branch
from
7afb66d to
1cff6a6
Compare
If the executed query doesn't return any data, we shouldn't send it to odoo as it will only pollute the Odoo job queue. Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
fix/empty_sample
branch
from
1cff6a6 to
4fc8a72
Compare
DebakelOrakel
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog