Prune the spec as suggested in review

appuio · Jan 13, 2025 · 45211d5 · 45211d5
1 parent f7ac183
commit 45211d5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/component/notifications.libsonnet b/component/notifications.libsonnet
@@ -18,13 +18,15 @@ local makeConsoleNotification(name, args) =
         'appuio.io/notification': 'true',
       },
     },
-    spec: {
-      text: args.text,
-      location: std.get(args, 'location', 'BannerTop'),
-      color: std.get(args, 'color', '#fff'),
-      backgroundColor: std.get(args, 'backgroundColor', '#2596be'),
-      link: std.get(args, 'link'),
-    },
+    spec: std.prune(
+      {
+        text: args.text,
+        location: std.get(args, 'location', 'BannerTop'),
+        color: std.get(args, 'color', '#fff'),
+        backgroundColor: std.get(args, 'backgroundColor', '#2596be'),
+        link: std.get(args, 'link'),
+      },
+    ),
   };
 
 local consoleNotifications = [

diff --git a/tests/golden/notifications/openshift4-console/openshift4-console/30_notifications.yaml b/tests/golden/notifications/openshift4-console/openshift4-console/30_notifications.yaml
@@ -26,6 +26,5 @@ metadata:
 spec:
   backgroundColor: '#2596be'
   color: '#fff'
-  link: null
   location: BannerTop
   text: Standard Notification