Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OpenShift Logging 5.8 #120

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Support OpenShift Logging 5.8 #120

merged 1 commit into from
Jan 11, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Jan 8, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel requested a review from a team as a code owner January 8, 2024 14:37
simu
simu approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd propose to check the changed alerts for 5.8 on the lab and create a follow-up PR if we want/need to tune any of them.

@DebakelOrakel DebakelOrakel force-pushed the dep/logging-5.8 branch 2 times, most recently from b0da30c to 990b7ab Compare January 10, 2024 15:23
@DebakelOrakel DebakelOrakel merged commit a79ee05 into master Jan 11, 2024
13 checks passed
@DebakelOrakel DebakelOrakel deleted the dep/logging-5.8 branch January 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DebakelOrakel @simu