Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct DNS resource group name #20

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

mrsheepuk
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📖 Terraform Documentation: success

Working Directory: modules/cloudaccess
Pusher: @mrsheepuk, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/6658191401

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📖 Terraform Documentation: success

Working Directory: .
Pusher: @mrsheepuk, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/6658191401

@mrsheepuk mrsheepuk force-pushed the fix-dns-resourcegroup branch from 639159f to aedd843 Compare October 26, 2023 18:19
Copy link
Contributor

@lewismarshall lewismarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all good

@lewismarshall lewismarshall merged commit 793b623 into vnext Oct 26, 2023
@KashifSaadat KashifSaadat deleted the fix-dns-resourcegroup branch October 31, 2023 15:45
mrsheepuk added a commit that referenced this pull request Nov 10, 2023
* Correct DNS resource group name
* Fix conditionals on federated role assignments
* Add tenant ID and remove principal ID from the outputs
mrsheepuk added a commit that referenced this pull request Nov 10, 2023
* Correct DNS resource group name
* Fix conditionals on federated role assignments
* Add tenant ID and remove principal ID from the outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants