Update installer and permissions so that private links work #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Review Status
Working Directory: |
asmith030
force-pushed
the
private-link-adam
branch
from
32f1f92 to
ab26134
Compare
Pull Request Review Status
Working Directory: |
asmith030
force-pushed
the
private-link-adam
branch
2 times, most recently
from
bafb0de to
76c3155
Compare
mrsheepuk
reviewed
Aug 20, 2024
KashifSaadat
force-pushed
the
vnext
branch
2 times, most recently
from
053a23a to
1499d43
Compare
asmith030
force-pushed
the
private-link-adam
branch
from
73a4b09 to
70c6cd8
Compare
asmith030
force-pushed
the
private-link-adam
branch
from
ee353c4 to
99ff36e
Compare
KashifSaadat
approved these changes
Sep 12, 2024
KashifSaadat
pushed a commit
that referenced
this pull request
Sep 16, 2024
Co-authored-by: Adam Smith <[email protected]>
KashifSaadat
added a commit
that referenced
this pull request
Sep 16, 2024
* chore: update Wayfinder to version 2.8.1 (#61) * chore: update Wayfinder to version 2.8.1 * chore: update kube version to 1.30 * feat: add permissions to installer for private links (#62) Co-authored-by: Adam Smith <[email protected]> * refactor: switch to supported kubectl provider (#67) * chore: update Wayfinder to version 2.8.1 (#61) * chore: update Wayfinder to version 2.8.1 * chore: update kube version to 1.30 * refactor: switch to supported kubectl provider --------- Co-authored-by: Lewis Marshall <[email protected]> --------- Co-authored-by: Lewis Marshall <[email protected]> Co-authored-by: Adam Smith <[email protected]> Co-authored-by: Adam Smith <[email protected]>
KashifSaadat
added a commit
that referenced
this pull request
Sep 16, 2024
* chore: update Wayfinder to version 2.8.1 (#61) * chore: update Wayfinder to version 2.8.1 * chore: update kube version to 1.30 * feat: add permissions to installer for private links (#62) Co-authored-by: Adam Smith <[email protected]> * refactor: switch to supported kubectl provider (#67) * chore: update Wayfinder to version 2.8.1 (#61) * chore: update Wayfinder to version 2.8.1 * chore: update kube version to 1.30 * refactor: switch to supported kubectl provider --------- Co-authored-by: Lewis Marshall <[email protected]> * feat: bump AKS nodepool version to 1.30 (#69) --------- Co-authored-by: Lewis Marshall <[email protected]> Co-authored-by: Adam Smith <[email protected]> Co-authored-by: Adam Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.