Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for disabling wayfinder default resources from being created on install or update #74

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: add support for disabling wayfinder default resources from being created on install or update #74

merged 1 commit into from
Dec 3, 2024

Conversation

KashifSaadat
Copy link
Member

No description provided.

@KashifSaadat KashifSaadat changed the base branch from main to vnext December 3, 2024 09:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/cloudaccess
Pusher: @KashifSaadat, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/12137203909

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @KashifSaadat, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-azurerm-wayfinder/actions/runs/12137203909

gambol99
gambol99 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KashifSaadat KashifSaadat merged commit c5bc86d into vnext Dec 3, 2024
22 checks passed
@KashifSaadat KashifSaadat deleted the no-defaults branch December 3, 2024 10:33
KashifSaadat added a commit that referenced this pull request Dec 5, 2024
@KashifSaadat
feat: add support for disabling wayfinder default resources from bein…
6ec1cf7 
…g created on install or update (#74) (#75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gambol99 gambol99 gambol99 approved these changes

@marcinc marcinc marcinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KashifSaadat @marcinc @gambol99