-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility issues #36
base: master
Are you sure you want to change the base?
Conversation
sparebytes
commented
Sep 20, 2017
- Enable strict null checks
- Add declaration files to source and npm package
- Ignore source *.d.ts files in npm package
Thanks for the great input! Some of your commits were also suggested by the other pull requests, so I have integrated that already. I am still thinking about the reflection integration. I have seen the approach when I created the package in the first place, but I decided not to go with any dependencies. On the other hand, it would be indeed much cleaner to use the reflection methods. |
I understand not wanting to add |
One of the great benefits for the real-world-use is for sure that you do not have to write "=undefined" for each property. And of course, with reflect-metadata the code of json2typescript gets cleaner itself. |
@andreas-aeschlimann |