feat: added create more functionality #2214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
ItzNotABug
requested changes
Aug 14, 2025
| @@ -26,6 +27,8 @@ | |||
|
|
|||
| let isSubmitting = $state(false); | |||
| let columnFormWrapper: HTMLDivElement | null = $state(null); | |||
| let createMore = $state(false); | |||
| let formResetKey = $state(0); | |||
There was a problem hiding this comment.
can we not use the createRow variable as a #key? The formResetKey += 1 isn't that nice.
Comment on lines
+81
to
+87
| if (createMore) { | ||
| createRow = createRowWritable(); | ||
| existingData = null; | ||
| formResetKey += 1; | ||
| await tick(); | ||
| focusFirstInput(); | ||
| } |
There was a problem hiding this comment.
should we not close the sheet if this option is false?
| onClick: async () => { | ||
| await create(); | ||
| if (createMore) { | ||
| throw new Error('Keep open'); |
| } | ||
| } | ||
| }} | ||
| {footer}> |
There was a problem hiding this comment.
we already add a snippet footer above, right?
| </Alert.Inline> | ||
| {/if} | ||
| </Layout.Stack> | ||
| {#key formResetKey} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a "Create more" toggle feature to the table row creation sidebar
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes