fix: pong response & chunked upload #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,7 @@ Dictionary<string, object> data | |||
| createdAt: map["$createdAt"].ToString(), | |||
| updatedAt: map["$updatedAt"].ToString(), | |||
| permissions: ((JArray)map["$permissions"]).ToObject<List<string>>(), | |||
| data: map | |||
| , data: map | |||
There was a problem hiding this comment.
hmm this doesnt look right
| @@ -19,7 +19,7 @@ Dictionary<string, object> data | |||
| } | |||
|
|
|||
| public static Preferences From(Dictionary<string, object> map) => new Preferences( | |||
| data: map | |||
| , data: map | |||
| @@ -718,7 +718,7 @@ static Models.User Convert(Dictionary<string, object> it) => | |||
| /// Delete an authenticator app. | |||
| /// </para> | |||
| /// </summary> | |||
| public Task<Models.User> DeleteMfaAuthenticator(string userId, Appwrite.Enums.AuthenticatorType type) | |||
| public Task<object> DeleteMfaAuthenticator(string userId, Appwrite.Enums.AuthenticatorType type) | |||
There was a problem hiding this comment.
should this be object? this endpoint returns no content 🤔
| min: map["min"] == null ? null : Convert.ToDouble(map["min"]), | ||
| max: map["max"] == null ? null : Convert.ToDouble(map["max"]), | ||
| xdefault: map["default"] == null ? null : Convert.ToDouble(map["default"]) | ||
| min: map["min"] == null ? null :Convert.ToDouble(map["min"]), |
There was a problem hiding this comment.
I believe the space was useful for readability
| min: map["min"] == null ? null : Convert.ToInt64(map["min"]), | ||
| max: map["max"] == null ? null : Convert.ToInt64(map["max"]), | ||
| xdefault: map["default"] == null ? null : Convert.ToInt64(map["default"]) | ||
| min: map["min"] == null ? null :Convert.ToInt64(map["min"]), |
christyjacob4
requested changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated SDK update