Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fixed) Documentation: Update Textmagic and Sendgrid screenshots #1173

Closed
wants to merge 3 commits into from
Closed

(Fixed) Documentation: Update Textmagic and Sendgrid screenshots #1173

wants to merge 3 commits into from

Conversation

iamAyushChamoli
Copy link

Fixes #1088

What does this PR do?

Updated the screenshots at https://appwrite.io/docs/products/messaging (Providers) with updated logos of Textmagic and Sendgrid.

Test Plan

Manually Tested.

Related PRs and Issues

#1088

Have you read the Contributing Guidelines on issues?

Yes

@choir241 choir241 self-requested a review August 6, 2024 15:58
Copy link
Contributor

@choir241 choir241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙏🏼 The screenshots look a little small and don't seem to have an aspect ratio that matches our style guide. Would you please make sure:

  • Screenshots must be 16:9
  • Screenshots should be taken in a 1400 x 900 view port on 3x DPR in browser developer tools.

@iamAyushChamoli
Copy link
Author

@stnguyen90 sure, I'll fix that

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aspect ratio looks right, but the size looks small...did you set the DPR to 3?

Also, it seems like the top of the screenshot is cut off. can you make sure that's not the case?

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshot doesn't look cut off anymore, but the DPR doesn't seem right. I expect the image to be much larger with a larger DPR.

One of the reasons why we need a higher DPR is to maintain clarity. When comparing the two images, the existing image looks much clearer. See the comparison between the new screenshot on the left and the existing image on the right:

image

@iamAyushChamoli
Copy link
Author

@stnguyen90 but I'm pretty sure I set the DPR to 3 this time. I rechecked it after each screenshot to verify the same. Should I change the DPR from 3 to a higher value?

@iamAyushChamoli iamAyushChamoli closed this by deleting the head repository Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Documentation: Update Textmagic and Sendgrid screenshots
3 participants