Fix: added original removed messaging providers doc page #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChiragAgg5k, next time, please make sure you ask to be assigned to the issue before submitting a PR. |
stnguyen90
requested changes
Dec 13, 2024
There was a problem hiding this comment.
We also need the link added to the sidebar under Concepts:
website/src/routes/docs/products/messaging/+layout.svelte
Lines 23 to 26 in f6f5b4b
|
sorry about that 😅 |
stnguyen90
requested changes
Dec 19, 2024
Comment on lines
23
to
26
| { | ||
| label: 'Providers', | ||
| href: '/docs/products/messaging/providers' | ||
| }, |
There was a problem hiding this comment.
Please fix the formatting.
Comment on lines
26
to
27
| {% cards_item href="/docs/products/messaging/sendgrid" title="Sendgrid" icon="icon-sendgrid" %} | ||
| Deliver custom email messages to users using Sendgrid. |
There was a problem hiding this comment.
Suggested change
| {% cards_item href="/docs/products/messaging/sendgrid" title="Sendgrid" icon="icon-sendgrid" %} | |
| Deliver custom email messages to users using Sendgrid. | |
| {% cards_item href="/docs/products/messaging/sendgrid" title="SendGrid" icon="icon-sendgrid" %} | |
| Deliver custom email messages to users using SendGrid. |
|
added the fixes |
|
@ChiragAgg5k, please make sure to re-request a review when you're all done with your changes: 
|
stnguyen90
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds back the originally removed
docs/products/messaging/providersdocumentation page. It was originally removed to make the providers more visible and easier to find, but some link according to issue #1479 still redirect to this page and having this page would still be beneficial.Test Plan
I have tested that the new page is rendering properly and updated the links to properly redirect to their respective documentations.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes I have.