No circ deps

[agheata]

This tries to remove the circular dependencies between libraries. Not yet linking.

[phsft-bot]

Can one of the admins verify this patch?

[JuanGonzalezCaminero]

This method is declared in the integration layer

[agheata]

Yes, this should go away as it is undefined, it doesn't cry just because it is not used in a templated class

[drbenmorgan]

At present, this is failing to build locally for me with the same error as on the CI:

[1/14] Linking CXX shared library CMakeFiles/AdePT_G4_integration.dir/cmake_device_link.o
FAILED: CMakeFiles/AdePT_G4_integration.dir/cmake_device_link.o 
/.../nvcc -forward-unknown-to-host-compiler -O2 -g -DNDEBUG --generate-code=arch=compute_86,code=[compute_86,sm_86] -Xnvlink --suppress-stack-size-warning -Xcompiler=-fPIC -Wno-deprecated-gpu-targets -shared -dlink CMakeFiles/AdePT_G4_integration.dir/src/AdePTTrackingManager.cc.o CMakeFiles/AdePT_G4_integration.dir/src/AdePTTrackingManager.cu.o CMakeFiles/AdePT_G4_integration.dir/src/AdePTPhysics.cc.o CMakeFiles/AdePT_G4_integration.dir/src/HepEMPhysics.cc.o CMakeFiles/AdePT_G4_integration.dir/src/AdePTGeant4Integration.cpp.o -o CMakeFiles/AdePT_G4_integration.dir/cmake_device_link.o -L/.../lib /.../lib64/libvecgeom.a /.../lib64/libvecgeomcuda_static.a /.../lib64/libvgdml.a -lrt -lpthread -ldl  -lcudadevrt -lcudart_static
nvlink error   : Undefined reference to '_ZN11HostScoring9RecordHitEcddPKN7vecgeom4cuda13NavStateIndexEPNS1_8Vector3DIdEES7_S7_ddS4_S7_S7_S7_dd' in 'CMakeFiles/AdePT_G4_integration.dir/src/AdePTTrackingManager.cu.o'
nvlink error   : Undefined reference to '_ZN11HostScoring15AccountProducedEiii' in 'CMakeFiles/AdePT_G4_integration.dir/src/AdePTTrackingManager.cu.o'

[JuanGonzalezCaminero]

Yes, in principle this happens because now AdePTTransport is templated on the integration layer. When we compile the AdePTTransport methods during compilation of AdePT_G4_Integration it needs to call HostScoring, but it doesn't have visibility of the implementation, which at this point is still part of libAdePT

We will move the scoring into headers as well and it should solve it