Moving AdePT Initialization to AdePTTrackingManager::BuildPhysicsTable #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
JuanGonzalezCaminero
force-pushed
the
init_order
branch
from
1e42851
to
47ef9db
Compare
agheata
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously AdePTTransport was initialized at AdePTPhysics::ConstructProcess. However at this point the material-cut couples are not yet initialized in Geant4, which means G4HepEM can't be initialized. The workaround was to manually initialize them in the user detector construction.
This PR delays the AdePT initialization until AdePTTrackingManager::BuildPhysicsTable, at which point we have all the information we need.
One downside of this approach is that now we have a pointer to AdePTConfiguration in AdePTTrackingManager, rather than AdePTPhysics being the only user of the configuration.