Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Aptible Enforcer #363

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Integrate with Aptible Enforcer #363

merged 2 commits into from
Dec 27, 2024

Conversation

mdelaossa
Copy link
Member

We should integrate with Enforcer as changes to this repo need integration tests ran against it

  • TODO (I can't do this)
    • Add necessary secrets to repo

@mdelaossa mdelaossa requested a review from aguilinger December 24, 2024 18:18
@mdelaossa mdelaossa removed the request for review from UserNotFound December 24, 2024 18:18

report-version:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo still uses master

I think it would be easy to switch but we can do that separately

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, my bad. I was focused on getting the curl edited correctly at the bottom and missed this entirely. Also removed the tool-versions file I shouldn't have committed

Copy link
Member

@aguilinger aguilinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secrets are org-wide ones so it shouldn't need to be set separately, though this is a public repo so that might change things. Let's try it first with just the org ones

@mdelaossa mdelaossa merged commit 9753155 into master Dec 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants