Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ignoring signatures on remote repos with only InRelease file #1308

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Jul 2, 2024

Fixes #237

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

If a remote repo has only InRelease but no Release file, aptly is not able to mirror it, even when -ignore-signatures is specified.

This change fixes this behavior, by trying to download the InRelease if Release file is not found, and strips and ignores the signature.

Checklist

  • functional test added/updated (if change is functional)

@neolynx neolynx self-assigned this Jul 2, 2024
@neolynx neolynx added the fix tests Tests are failing label Jul 2, 2024
@neolynx neolynx added needs review Ready for review & merge and removed needs implementation WIP fix tests Tests are failing labels Jul 2, 2024
@neolynx neolynx requested a review from a team July 2, 2024 23:19
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (4661913) to head (0f5f648).

Files Patch % Lines
deb/remote.go 47.36% 6 Missing and 4 partials ⚠️
pgp/gnupg.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
- Coverage   74.53%   74.47%   -0.06%     
==========================================
  Files         146      146              
  Lines       16576    16597      +21     
==========================================
+ Hits        12355    12361       +6     
- Misses       3245     3257      +12     
- Partials      976      979       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx added increase coverage The PR lacks test coverage labels Jul 2, 2024
@neolynx neolynx changed the title allow not signed mirrors without InRelease file fix ignoring signatures on remote repos with only InRelease file Jul 3, 2024
@neolynx neolynx removed the increase coverage The PR lacks test coverage label Jul 3, 2024
@neolynx neolynx merged commit d8c1e43 into master Jul 3, 2024
9 checks passed
@neolynx neolynx deleted the fix/mirror-ignore-signatures branch July 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Ready for review & merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mirror repository without Release file
2 participants