Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission check to account #14535

Draft
wants to merge 1 commit into
base: asset_permission
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 5, 2024

⏱️ 3h 5m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 20m 🟩
rust-move-unit-coverage 19m 🟩
rust-move-unit-coverage 16m 🟩
rust-move-unit-coverage 15m 🟩
rust-move-unit-coverage 14m 🟩
general-lints 13m 🟩🟩🟩🟩🟩 (+2 more)
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-unit-coverage 11m 🟩
check-dynamic-deps 11m 🟩🟩🟩🟩🟩 (+4 more)
rust-move-tests 9m 🟥
rust-move-tests 8m 🟥
rust-move-tests 8m 🟥
rust-move-tests 8m 🟥
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 3m

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 703921b to 48991ff Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 05cd155 to 19324d8 Compare September 9, 2024 07:08
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (asset_permission@444ac11). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             asset_permission   #14535   +/-   ##
===================================================
  Coverage                    ?    59.4%           
===================================================
  Files                       ?      857           
  Lines                       ?   210762           
  Branches                    ?        0           
===================================================
  Hits                        ?   125197           
  Misses                      ?    85565           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 48991ff to 906c7c7 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 19324d8 to 0a93383 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 906c7c7 to 350db4c Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 0a93383 to bde486a Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou changed the base branch from 09-04-implement_rust_logics_for_permissioned_signer to asset_permission September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from bde486a to 5fc08ad Compare September 9, 2024 17:55
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 5fc08ad to da28781 Compare September 10, 2024 17:25
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from da28781 to 006ad4c Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 006ad4c to ef7abd3 Compare September 12, 2024 01:50
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from ef7abd3 to c38c2dd Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from c38c2dd to 95b6704 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 95b6704 to 7394967 Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from e49c386 to 594644d Compare November 26, 2024 18:07
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch 2 times, most recently from 7b805b0 to 0d70077 Compare November 26, 2024 18:21
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 0d70077 to 8e6ca98 Compare November 26, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 8e6ca98 to 1302c7b Compare November 26, 2024 22:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 1302c7b to 4bec214 Compare November 26, 2024 23:15
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 4bec214 to 3e1120c Compare November 27, 2024 03:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 3e1120c to 6f4f49a Compare November 27, 2024 06:59
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 6f4f49a to bfc0817 Compare November 27, 2024 07:16
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from bfc0817 to a8ca890 Compare November 27, 2024 07:49
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from a8ca890 to 20ce45e Compare November 27, 2024 08:22
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 20ce45e to f1841c6 Compare November 27, 2024 08:40
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from f1841c6 to da2d989 Compare December 2, 2024 02:40
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from da2d989 to c124e6c Compare December 2, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants