Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump runs-on image to latest version #14596

Merged
merged 1 commit into from
Sep 11, 2024
Merged

bump runs-on image to latest version #14596

merged 1 commit into from
Sep 11, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Sep 11, 2024

Description

Bump the runs-on AMI to the latest image. Our build deps were updated in #14487

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from ibalajiarun, rahxephon89 and a team September 11, 2024 15:54
@aluon aluon requested a review from a team as a code owner September 11, 2024 15:54
Copy link

trunk-io bot commented Sep 11, 2024

@aluon aluon enabled auto-merge (squash) September 11, 2024 18:43

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d622fdf3b1f71694f84fa70a1de0e31a54600b4a

two traffics test: inner traffic : committed: 13033.08 txn/s, latency: 3053.77 ms, (p50: 2700 ms, p70: 3000, p90: 4200 ms, p99: 5100 ms), latency samples: 4955440
two traffics test : committed: 100.06 txn/s, latency: 3070.96 ms, (p50: 2500 ms, p70: 3600, p90: 4400 ms, p99: 11000 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.241, avg: 0.218", "QsPosToProposal: max: 0.284, avg: 0.237", "ConsensusProposalToOrdered: max: 0.318, avg: 0.298", "ConsensusOrderedToCommit: max: 0.466, avg: 0.444", "ConsensusProposalToCommit: max: 0.769, avg: 0.742"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.89s no progress at version 2794219 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.69s no progress at version 2794215 (avg 7.69s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> d622fdf3b1f71694f84fa70a1de0e31a54600b4a

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> d622fdf3b1f71694f84fa70a1de0e31a54600b4a (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 10959.33 txn/s, latency: 2906.60 ms, (p50: 1900 ms, p70: 2100, p90: 7600 ms, p99: 17600 ms), latency samples: 374000
2. Upgrading first Validator to new version: d622fdf3b1f71694f84fa70a1de0e31a54600b4a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7249.76 txn/s, latency: 3916.81 ms, (p50: 4300 ms, p70: 4600, p90: 4800 ms, p99: 4900 ms), latency samples: 139200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7544.91 txn/s, latency: 4269.16 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 253900
3. Upgrading rest of first batch to new version: d622fdf3b1f71694f84fa70a1de0e31a54600b4a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5629.72 txn/s, latency: 5247.78 ms, (p50: 6000 ms, p70: 6300, p90: 6600 ms, p99: 6700 ms), latency samples: 115560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5104.42 txn/s, latency: 6473.31 ms, (p50: 6800 ms, p70: 7000, p90: 7600 ms, p99: 8800 ms), latency samples: 177020
4. upgrading second batch to new version: d622fdf3b1f71694f84fa70a1de0e31a54600b4a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12252.23 txn/s, latency: 2211.33 ms, (p50: 2400 ms, p70: 2500, p90: 2600 ms, p99: 2700 ms), latency samples: 210540
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12004.63 txn/s, latency: 2582.84 ms, (p50: 2500 ms, p70: 2600, p90: 3000 ms, p99: 4800 ms), latency samples: 389480
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> d622fdf3b1f71694f84fa70a1de0e31a54600b4a passed
Test Ok

@aluon aluon merged commit 361fcbd into main Sep 11, 2024
88 checks passed
@aluon aluon deleted the aluon/bump-runs-on-ami branch September 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants