[compiler-v2] add test cases for lambda #14791

brmataptos · 2024-09-28T04:23:39Z

Description

Add a /lambda/ test subdir for move-compiler-v2, and test it with LAMBDA experiments off (.exp) and on (.lambda.exp).

How Has This Been Tested?

This is just a test.

Key Areas to Review

Observe baselines. Can you think of any other useful tests to include? If not, just approve, please.

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-28T04:23:43Z

⏱️ 3h 43m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-cargo-deny	15m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	12m	🟩
rust-move-unit-coverage	11m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-tests	10m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-tests	10m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-unit-coverage	10m	🟩
general-lints	10m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

brmataptos · 2024-09-28T04:23:47Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-09-28T04:43:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (918b643) to head (c99de22).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14791   +/-   ##
=======================================
  Coverage    60.1%    60.1%           
=======================================
  Files         856      856           
  Lines      210845   210845           
=======================================
+ Hits       126742   126761   +19     
+ Misses      84103    84084   -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vineethk · 2024-09-29T20:06:22Z

third_party/move/move-compiler-v2/tests/testsuite.rs

            options: opts
                .clone()
+                // .set_experiment(Experiment::AST_SIMPLIFY, true)


Can we remove this commented out code?

vineethk · 2024-09-29T20:07:17Z

third_party/move/move-compiler-v2/tests/testsuite.rs

@@ -213,7 +214,7 @@ const TEST_CONFIGS: Lazy<BTreeMap<&str, TestConfig>> = Lazy::new(|| {
        TestConfig {


In the comment above, add "lambdas" as well.

vineethk · 2024-09-29T20:13:11Z

third_party/move/move-compiler-v2/tests/lambda/non_lambda_arg.lambda.exp

+
+
+Diagnostics:
+error: local `a_less_b` of type `|(T, T)|bool` does not have the `copy` ability


I am assuming we should we ignore weird errors in lambda.exp for now, because these will change once lambdas are implemented?

github-actions · 2024-10-21T07:38:54Z

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `7cfe2c4832ed13365b51ce987cd2afc460d0880b`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 12875.49 txn/s, latency: 2519.90 ms, (p50: 1900 ms, p70: 2100, p90: 2800 ms, p99: 18100 ms), latency samples: 517480
2. Upgrading first Validator to new version: 7cfe2c4832ed13365b51ce987cd2afc460d0880b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5998.40 txn/s, latency: 4796.86 ms, (p50: 5400 ms, p70: 5700, p90: 6000 ms, p99: 6100 ms), latency samples: 113140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5413.89 txn/s, latency: 5930.73 ms, (p50: 6400 ms, p70: 6500, p90: 7300 ms, p99: 8000 ms), latency samples: 182800
3. Upgrading rest of first batch to new version: 7cfe2c4832ed13365b51ce987cd2afc460d0880b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5513.62 txn/s, latency: 5305.97 ms, (p50: 5800 ms, p70: 6300, p90: 6600 ms, p99: 6700 ms), latency samples: 112060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5330.44 txn/s, latency: 6082.05 ms, (p50: 6600 ms, p70: 6900, p90: 7300 ms, p99: 7800 ms), latency samples: 187900
4. upgrading second batch to new version: 7cfe2c4832ed13365b51ce987cd2afc460d0880b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8602.64 txn/s, latency: 3177.74 ms, (p50: 3400 ms, p70: 3500, p90: 3900 ms, p99: 4300 ms), latency samples: 156380
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8043.28 txn/s, latency: 3839.68 ms, (p50: 3500 ms, p70: 3700, p90: 7100 ms, p99: 8100 ms), latency samples: 285960
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b passed
Test Ok

github-actions · 2024-10-21T07:39:24Z

✅ Forge suite `realistic_env_max_load` success on `7cfe2c4832ed13365b51ce987cd2afc460d0880b`

two traffics test: inner traffic : committed: 13214.35 txn/s, latency: 2998.68 ms, (p50: 2700 ms, p70: 2900, p90: 3300 ms, p99: 9900 ms), latency samples: 5024580
two traffics test : committed: 99.97 txn/s, latency: 1679.18 ms, (p50: 1500 ms, p70: 1600, p90: 1900 ms, p99: 3900 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.231, avg: 0.215", "QsPosToProposal: max: 1.166, avg: 0.945", "ConsensusProposalToOrdered: max: 0.317, avg: 0.307", "ConsensusOrderedToCommit: max: 0.557, avg: 0.507", "ConsensusProposalToCommit: max: 0.862, avg: 0.814"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.13s no progress at version 2214098 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.93s no progress at version 2214096 (avg 7.93s) [limit 15].
Test Ok

github-actions · 2024-10-21T07:40:36Z

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `7cfe2c4832ed13365b51ce987cd2afc460d0880b`

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b (PR)
Upgrade the nodes to version: 7cfe2c4832ed13365b51ce987cd2afc460d0880b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1300.36 txn/s, submitted: 1303.54 txn/s, failed submission: 3.18 txn/s, expired: 3.18 txn/s, latency: 2394.44 ms, (p50: 2400 ms, p70: 2700, p90: 3300 ms, p99: 4700 ms), latency samples: 114420
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1267.52 txn/s, submitted: 1270.04 txn/s, failed submission: 2.52 txn/s, expired: 2.52 txn/s, latency: 2427.25 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 6600 ms), latency samples: 110620
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b passed
Upgrade the remaining nodes to version: 7cfe2c4832ed13365b51ce987cd2afc460d0880b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1146.65 txn/s, submitted: 1149.29 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2498.50 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5800 ms), latency samples: 104360
Test Ok

brmataptos mentioned this pull request Sep 28, 2024

[move-compiler-v2] fix #14633: fix error messages for lambdas, identify change points for more complete lambda implementation #14742

Merged

22 tasks

brmataptos marked this pull request as ready for review September 28, 2024 04:24

brmataptos requested review from fEst1ck, rahxephon89, vineethk and wrwg September 28, 2024 04:28

brmataptos force-pushed the 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation branch from 61459eb to 0f3224a Compare September 28, 2024 04:32

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from 78767d3 to 7f59256 Compare September 28, 2024 04:32

brmataptos mentioned this pull request Sep 28, 2024

[move-compiler-v2] add parser code for lambda types #14792

Merged

22 tasks

vineethk approved these changes Sep 29, 2024

View reviewed changes

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch 2 times, most recently from ae73f37 to 243ea0f Compare September 30, 2024 18:43

brmataptos force-pushed the 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation branch from a8dba3c to 9b0ccd6 Compare October 3, 2024 01:42

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from 243ea0f to f3d30eb Compare October 3, 2024 01:42

brmataptos force-pushed the 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation branch from 9b0ccd6 to e8a6216 Compare October 3, 2024 01:52

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch 2 times, most recently from 0cc6890 to 1b54f30 Compare October 3, 2024 04:42

brmataptos force-pushed the 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation branch from a050828 to 8a317b8 Compare October 3, 2024 17:01

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from ad600f0 to 017f471 Compare October 3, 2024 17:01

wrwg changed the title ~~add test cases for lambda~~ [compiler-vc] add test cases for lambda Oct 3, 2024

wrwg changed the title ~~[compiler-vc] add test cases for lambda~~ [compiler-v2] add test cases for lambda Oct 3, 2024

wrwg approved these changes Oct 3, 2024

View reviewed changes

brmataptos force-pushed the 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation branch from 8a317b8 to f72846f Compare October 10, 2024 04:17

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from 017f471 to b7d429a Compare October 10, 2024 04:18

Base automatically changed from 09-24-fix_14633_fix_error_messages_for_lambdas_identify_change_points_for_more_complete_lambda_implementation to main October 10, 2024 04:56

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from b7d429a to c99de22 Compare October 10, 2024 05:25

brmataptos enabled auto-merge (squash) October 10, 2024 05:27

This comment has been minimized.

Sign in to view

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch 2 times, most recently from d3254ad to 7e21319 Compare October 18, 2024 18:08

This comment has been minimized.

Sign in to view

brmataptos added 4 commits October 21, 2024 00:07

add test cases for lambda

164e0c3

update test outputs after changes to last PR

6c0c10b

update test outputs after merge

37ac071

update test outputs again

7cfe2c4

brmataptos force-pushed the 09-27-extend_parser_for_lambda_types branch from 7e21319 to 7cfe2c4 Compare October 21, 2024 07:10

This comment has been minimized.

Sign in to view

brmataptos merged commit 38aedc2 into main Oct 21, 2024
48 checks passed

brmataptos deleted the 09-27-extend_parser_for_lambda_types branch October 21, 2024 07:48

This was referenced Nov 22, 2024

[move-compiler-v2] clean up a few remaining issues in lambda parser/front-end code #15365

Open

Lambda support in VM: Wolfgang's PR plus some simplifications (removing mask, clarifying ops) #15387

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[compiler-v2] add test cases for lambda #14791

[compiler-v2] add test cases for lambda #14791

brmataptos commented Sep 28, 2024 •

edited

Loading

trunk-io bot commented Sep 28, 2024 •

edited

Loading

brmataptos commented Sep 28, 2024 •

edited

Loading

codecov bot commented Sep 28, 2024 •

edited

Loading

vineethk Sep 29, 2024

vineethk Sep 29, 2024

vineethk Sep 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

		@@ -213,7 +214,7 @@ const TEST_CONFIGS: Lazy<BTreeMap<&str, TestConfig>> = Lazy::new(\|\| {
		TestConfig {



		Diagnostics:
		error: local `a_less_b` of type `\|(T, T)\|bool` does not have the `copy` ability

[compiler-v2] add test cases for lambda #14791

[compiler-v2] add test cases for lambda #14791

Conversation

brmataptos commented Sep 28, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Sep 28, 2024 • edited Loading

brmataptos commented Sep 28, 2024 • edited Loading

codecov bot commented Sep 28, 2024 • edited Loading

Codecov Report

vineethk Sep 29, 2024

Choose a reason for hiding this comment

vineethk Sep 29, 2024

Choose a reason for hiding this comment

vineethk Sep 29, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 21, 2024

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b

github-actions bot commented Oct 21, 2024

✅ Forge suite realistic_env_max_load success on 7cfe2c4832ed13365b51ce987cd2afc460d0880b

github-actions bot commented Oct 21, 2024

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7cfe2c4832ed13365b51ce987cd2afc460d0880b

brmataptos commented Sep 28, 2024 •

edited

Loading

trunk-io bot commented Sep 28, 2024 •

edited

Loading

brmataptos commented Sep 28, 2024 •

edited

Loading

codecov bot commented Sep 28, 2024 •

edited

Loading

✅ Forge suite `compat` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `7cfe2c4832ed13365b51ce987cd2afc460d0880b`

✅ Forge suite `realistic_env_max_load` success on `7cfe2c4832ed13365b51ce987cd2afc460d0880b`

✅ Forge suite `framework_upgrade` success on `b29f09f57e898d8d211c8bc3e303f6e50bba2266` ==> `7cfe2c4832ed13365b51ce987cd2afc460d0880b`