[cp 1.24] Move payload_manager.notify_commit to after commit

[msmouse]

this is to cherry-pick #15361 to v1.24

[trunk-io]

⏱️ 4h 1m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	1h 20m	🟥 🟩 🟩 🟩
rust-unit-tests	23m	🟩
rust-unit-tests	22m	🟩
rust-unit-tests	21m	🟩
execution-performance / test-target-determinator	13m	🟩 🟩 🟩
test-target-determinator	12m	🟩 🟩 🟩
check	11m	🟩 🟩 🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-cargo-deny	5m	🟩 🟩 🟩
fetch-last-released-docker-image-tag	5m	🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	26m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[github-actions]

✅ Forge suite realistic_env_max_load success on d07f229804ab73eb1b9050f97fa22b677da282aa

two traffics test: inner traffic : committed: 14002.19 txn/s, latency: 2836.65 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 12600 ms), latency samples: 5323980
two traffics test : committed: 100.04 txn/s, latency: 1501.12 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 6000 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.018, avg: 1.567", "ConsensusProposalToOrdered: max: 0.328, avg: 0.295", "ConsensusOrderedToCommit: max: 0.380, avg: 0.369", "ConsensusProposalToCommit: max: 0.675, avg: 0.664"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.04s no progress at version 1185119 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.65s no progress at version 5529143 (avg 8.52s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa (PR)
Upgrade the nodes to version: d07f229804ab73eb1b9050f97fa22b677da282aa
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1438.13 txn/s, submitted: 1441.33 txn/s, failed submission: 3.20 txn/s, expired: 3.20 txn/s, latency: 2175.39 ms, (p50: 1800 ms, p70: 2100, p90: 3600 ms, p99: 5600 ms), latency samples: 125880
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1344.07 txn/s, submitted: 1347.57 txn/s, failed submission: 3.50 txn/s, expired: 3.50 txn/s, latency: 2167.18 ms, (p50: 2100 ms, p70: 2400, p90: 2900 ms, p99: 5100 ms), latency samples: 122800
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa passed
Upgrade the remaining nodes to version: d07f229804ab73eb1b9050f97fa22b677da282aa
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1343.77 txn/s, submitted: 1345.99 txn/s, failed submission: 2.22 txn/s, expired: 2.22 txn/s, latency: 2439.45 ms, (p50: 2100 ms, p70: 2400, p90: 4500 ms, p99: 5700 ms), latency samples: 120940
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa (PR)
1. Check liveness of validators at old version: 78db50320d1ba1ca1a61adb189b0b4fde0098f27
compatibility::simple-validator-upgrade::liveness-check : committed: 14767.05 txn/s, latency: 2142.48 ms, (p50: 1800 ms, p70: 1900, p90: 2400 ms, p99: 13600 ms), latency samples: 574740
2. Upgrading first Validator to new version: d07f229804ab73eb1b9050f97fa22b677da282aa
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7807.58 txn/s, latency: 3532.51 ms, (p50: 3500 ms, p70: 4300, p90: 4700 ms, p99: 5000 ms), latency samples: 144380
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7573.01 txn/s, latency: 4180.94 ms, (p50: 4300 ms, p70: 4400, p90: 6200 ms, p99: 6500 ms), latency samples: 253120
3. Upgrading rest of first batch to new version: d07f229804ab73eb1b9050f97fa22b677da282aa
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7718.99 txn/s, latency: 3695.24 ms, (p50: 4000 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 143780
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7703.67 txn/s, latency: 4147.44 ms, (p50: 4300 ms, p70: 4400, p90: 5900 ms, p99: 6100 ms), latency samples: 253580
4. upgrading second batch to new version: d07f229804ab73eb1b9050f97fa22b677da282aa
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11732.26 txn/s, latency: 2346.08 ms, (p50: 2500 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 203760
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11108.32 txn/s, latency: 2826.04 ms, (p50: 2700 ms, p70: 2800, p90: 4800 ms, p99: 5900 ms), latency samples: 360540
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> d07f229804ab73eb1b9050f97fa22b677da282aa passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking