[cp][aptos-release-v1.24] [consensus] sync improvements to help slow nodes sync better #15377

github-actions · 2024-11-22T22:17:30Z

Backport

This will backport the following commits from main to aptos-release-v1.24:

Questions ?

Please refer to the Backport tool documentation

* [qs] grace period before GC committed batches * [consensus] trigger sync based on remote LI timestamp (cherry picked from commit d672085)

trunk-io · 2024-11-22T22:17:33Z

⏱️ 2h 35m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	48m	🟩 🟩
rust-unit-tests	21m	🟩
rust-unit-tests	21m	🟩
test-target-determinator	9m	🟩 🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
execution-performance / test-target-determinator	8m	🟩 🟩
check	7m	🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-cargo-deny	4m	🟩 🟩
check-dynamic-deps	3m	🟩 🟩
fetch-last-released-docker-image-tag	3m	🟩 🟩
general-lints	54s	🟩 🟩
semgrep/ci	53s	🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

This reverts commit af0b055.

github-actions · 2024-11-23T02:44:31Z

✅ Forge suite `realistic_env_max_load` success on `35e6015339d5e043dd9040025ddc2cd5e0a82c00`

two traffics test: inner traffic : committed: 14128.87 txn/s, latency: 2812.65 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4900 ms), latency samples: 5372100
two traffics test : committed: 99.89 txn/s, latency: 2132.99 ms, (p50: 1500 ms, p70: 1900, p90: 2200 ms, p99: 16900 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.211, avg: 1.317", "ConsensusProposalToOrdered: max: 0.336, avg: 0.295", "ConsensusOrderedToCommit: max: 0.382, avg: 0.361", "ConsensusProposalToCommit: max: 0.672, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.21s no progress at version 56331 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.59s no progress at version 2796152 (avg 15.59s) [limit 16].
Test Ok

github-actions · 2024-11-23T02:46:58Z

✅ Forge suite `framework_upgrade` success on `527870ea43c9bb24f1e8f63f88c03bd42ee77855` ==> `35e6015339d5e043dd9040025ddc2cd5e0a82c00`

Compatibility test results for 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00 (PR)
Upgrade the nodes to version: 35e6015339d5e043dd9040025ddc2cd5e0a82c00
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1435.69 txn/s, submitted: 1439.78 txn/s, failed submission: 4.09 txn/s, expired: 4.09 txn/s, latency: 2156.77 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4800 ms), latency samples: 126500
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1422.23 txn/s, submitted: 1424.02 txn/s, failed submission: 1.80 txn/s, expired: 1.80 txn/s, latency: 2112.08 ms, (p50: 1800 ms, p70: 2100, p90: 3300 ms, p99: 4800 ms), latency samples: 126660
5. check swarm health
Compatibility test for 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00 passed
Upgrade the remaining nodes to version: 35e6015339d5e043dd9040025ddc2cd5e0a82c00
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1422.67 txn/s, submitted: 1425.42 txn/s, failed submission: 2.75 txn/s, expired: 2.75 txn/s, latency: 2339.43 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5800 ms), latency samples: 124340
Test Ok

github-actions · 2024-11-23T02:48:15Z

✅ Forge suite `compat` success on `527870ea43c9bb24f1e8f63f88c03bd42ee77855` ==> `35e6015339d5e043dd9040025ddc2cd5e0a82c00`

Compatibility test results for 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00 (PR)
1. Check liveness of validators at old version: 527870ea43c9bb24f1e8f63f88c03bd42ee77855
compatibility::simple-validator-upgrade::liveness-check : committed: 17807.84 txn/s, latency: 1907.75 ms, (p50: 1900 ms, p70: 2000, p90: 2100 ms, p99: 2300 ms), latency samples: 572260
2. Upgrading first Validator to new version: 35e6015339d5e043dd9040025ddc2cd5e0a82c00
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7463.52 txn/s, latency: 3636.77 ms, (p50: 3900 ms, p70: 4200, p90: 5100 ms, p99: 5200 ms), latency samples: 134320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7982.43 txn/s, latency: 4024.96 ms, (p50: 4100 ms, p70: 4200, p90: 6100 ms, p99: 6300 ms), latency samples: 261680
3. Upgrading rest of first batch to new version: 35e6015339d5e043dd9040025ddc2cd5e0a82c00
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7418.56 txn/s, latency: 3866.65 ms, (p50: 4200 ms, p70: 4500, p90: 4600 ms, p99: 4700 ms), latency samples: 140760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6731.21 txn/s, latency: 4782.09 ms, (p50: 4700 ms, p70: 4800, p90: 7000 ms, p99: 7300 ms), latency samples: 234180
4. upgrading second batch to new version: 35e6015339d5e043dd9040025ddc2cd5e0a82c00
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11625.99 txn/s, latency: 2335.92 ms, (p50: 2300 ms, p70: 2500, p90: 3700 ms, p99: 3900 ms), latency samples: 201220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11387.88 txn/s, latency: 2754.56 ms, (p50: 2600 ms, p70: 2600, p90: 5000 ms, p99: 6500 ms), latency samples: 368660
5. check swarm health
Compatibility test for 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00 passed
Test Ok

trunk-io · 2024-11-23T03:13:02Z

_{View Full Report ↗︎ ⋅ Docs}

[consensus] sync improvements to help slow nodes sync better (#15364)

6b15ea0

* [qs] grace period before GC committed batches * [consensus] trigger sync based on remote LI timestamp (cherry picked from commit d672085)

github-actions bot requested review from bchocho and sasha8 as code owners November 22, 2024 22:17

github-actions bot assigned thepomeranian Nov 22, 2024

github-actions bot requested review from gelash, zekun000 and ibalajiarun as code owners November 22, 2024 22:17

github-actions bot added the cherry-pick label Nov 22, 2024

github-actions bot mentioned this pull request Nov 22, 2024

[consensus] sync improvements to help slow nodes sync better #15364

Merged

ibalajiarun approved these changes Nov 22, 2024

View reviewed changes

msmouse approved these changes Nov 22, 2024

View reviewed changes

ibalajiarun enabled auto-merge (squash) November 22, 2024 22:26

This comment has been minimized.

Sign in to view

Revert "[consensus] trigger sync based on remote LI timestamp"

35e6015

This reverts commit af0b055.

This comment has been minimized.

Sign in to view

ibalajiarun merged commit 9497626 into aptos-release-v1.24 Nov 23, 2024
48 checks passed

ibalajiarun deleted the backport/aptos-release-v1.24/pr-15364 branch November 23, 2024 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cp][aptos-release-v1.24] [consensus] sync improvements to help slow nodes sync better #15377

[cp][aptos-release-v1.24] [consensus] sync improvements to help slow nodes sync better #15377

github-actions bot commented Nov 22, 2024 •

edited by ibalajiarun

Loading

trunk-io bot commented Nov 22, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 23, 2024

github-actions bot commented Nov 23, 2024

github-actions bot commented Nov 23, 2024

trunk-io bot commented Nov 23, 2024

[cp][aptos-release-v1.24] [consensus] sync improvements to help slow nodes sync better #15377

[cp][aptos-release-v1.24] [consensus] sync improvements to help slow nodes sync better #15377

Conversation

github-actions bot commented Nov 22, 2024 • edited by ibalajiarun Loading

Backport

Questions ?

trunk-io bot commented Nov 22, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 23, 2024

✅ Forge suite realistic_env_max_load success on 35e6015339d5e043dd9040025ddc2cd5e0a82c00

github-actions bot commented Nov 23, 2024

✅ Forge suite framework_upgrade success on 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00

github-actions bot commented Nov 23, 2024

✅ Forge suite compat success on 527870ea43c9bb24f1e8f63f88c03bd42ee77855 ==> 35e6015339d5e043dd9040025ddc2cd5e0a82c00

trunk-io bot commented Nov 23, 2024

github-actions bot commented Nov 22, 2024 •

edited by ibalajiarun

Loading

trunk-io bot commented Nov 22, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `35e6015339d5e043dd9040025ddc2cd5e0a82c00`

✅ Forge suite `framework_upgrade` success on `527870ea43c9bb24f1e8f63f88c03bd42ee77855` ==> `35e6015339d5e043dd9040025ddc2cd5e0a82c00`

✅ Forge suite `compat` success on `527870ea43c9bb24f1e8f63f88c03bd42ee77855` ==> `35e6015339d5e043dd9040025ddc2cd5e0a82c00`