update qs key loading #15401

zjma · 2024-11-26T00:31:29Z

Description

consensus key rotation was updated in #13926 .
QS should have been updated accordingly.

How Has This Been Tested?

existing tests.

Key Areas to Review

n/a

Type of Change

Refactoring

Which Components or Systems Does This Change Impact?

Validator Node

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-26T00:31:32Z

⏱️ 3h 16m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
test-target-determinator	23m	🟩 🟩 🟩 🟩 🟩
execution-performance / test-target-determinator	22m	🟩 🟩 🟩 🟩 🟩
check	18m	🟩 🟩 🟥 🟩 🟩 (+1 more)
rust-move-tests	13m	🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-cargo-deny	11m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests	11m	⬜
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩 (+1 more)
fetch-last-released-docker-image-tag	8m	🟩 🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	10s	18m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

ibalajiarun · 2024-11-26T06:00:14Z

consensus/src/epoch_manager.rs

@@ -669,6 +669,7 @@ impl<P: OnChainConfigProvider> EpochManager<P> {
        epoch_state: &EpochState,
        network_sender: NetworkSender,
        consensus_config: &OnChainConsensusConfig,
+        consensus_key: Option<Arc<PrivateKey>>,


Because this is required, can we remove the Option?

ibalajiarun

LGTM. Thanks!

ibalajiarun

LGTM. Thanks!

github-actions · 2024-11-28T02:13:27Z

✅ Forge suite `realistic_env_max_load` success on `20d86ec5bddbd1470d27a79baea0522d2c02c216`

two traffics test: inner traffic : committed: 13900.31 txn/s, latency: 2859.13 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 10300 ms), latency samples: 5285300
two traffics test : committed: 99.99 txn/s, latency: 1924.93 ms, (p50: 1600 ms, p70: 2000, p90: 2200 ms, p99: 16500 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.569, avg: 1.355", "ConsensusProposalToOrdered: max: 0.314, avg: 0.295", "ConsensusOrderedToCommit: max: 0.388, avg: 0.373", "ConsensusProposalToCommit: max: 0.680, avg: 0.667"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.15s no progress at version 38844 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.67s no progress at version 2736486 (avg 15.67s) [limit 16].
Test Ok

github-actions · 2024-11-28T02:15:01Z

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `20d86ec5bddbd1470d27a79baea0522d2c02c216`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 20d86ec5bddbd1470d27a79baea0522d2c02c216 (PR)
Upgrade the nodes to version: 20d86ec5bddbd1470d27a79baea0522d2c02c216
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1327.56 txn/s, submitted: 1329.97 txn/s, failed submission: 2.41 txn/s, expired: 2.41 txn/s, latency: 2187.85 ms, (p50: 2100 ms, p70: 2300, p90: 3400 ms, p99: 4700 ms), latency samples: 121160
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1435.23 txn/s, submitted: 1438.13 txn/s, failed submission: 2.90 txn/s, expired: 2.90 txn/s, latency: 2154.59 ms, (p50: 1800 ms, p70: 2200, p90: 3600 ms, p99: 4800 ms), latency samples: 128620
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 20d86ec5bddbd1470d27a79baea0522d2c02c216 passed
Upgrade the remaining nodes to version: 20d86ec5bddbd1470d27a79baea0522d2c02c216
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1347.02 txn/s, submitted: 1349.26 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2303.90 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5000 ms), latency samples: 120300
Test Ok

github-actions · 2024-11-28T02:15:57Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `20d86ec5bddbd1470d27a79baea0522d2c02c216`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 20d86ec5bddbd1470d27a79baea0522d2c02c216 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14522.21 txn/s, latency: 2000.62 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2500 ms), latency samples: 548240
2. Upgrading first Validator to new version: 20d86ec5bddbd1470d27a79baea0522d2c02c216
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7581.19 txn/s, latency: 3800.76 ms, (p50: 4200 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 142540
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6743.00 txn/s, latency: 4791.70 ms, (p50: 4700 ms, p70: 4800, p90: 7100 ms, p99: 7300 ms), latency samples: 234180
3. Upgrading rest of first batch to new version: 20d86ec5bddbd1470d27a79baea0522d2c02c216
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7015.18 txn/s, latency: 3964.42 ms, (p50: 4400 ms, p70: 4500, p90: 5300 ms, p99: 5500 ms), latency samples: 133740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7621.09 txn/s, latency: 4255.33 ms, (p50: 4400 ms, p70: 4500, p90: 6300 ms, p99: 6500 ms), latency samples: 252040
4. upgrading second batch to new version: 20d86ec5bddbd1470d27a79baea0522d2c02c216
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11424.03 txn/s, latency: 2458.99 ms, (p50: 2600 ms, p70: 2800, p90: 3200 ms, p99: 3400 ms), latency samples: 199620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9335.44 txn/s, latency: 3017.96 ms, (p50: 2900 ms, p70: 3100, p90: 3400 ms, p99: 6800 ms), latency samples: 357600
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 20d86ec5bddbd1470d27a79baea0522d2c02c216 passed
Test Ok

qs key update

706a4d2

zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 26, 2024