-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DoStateCheckpoint off critical path #15411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 56m total CI duration on this PR
|
0eb8d0e
to
ddaade9
Compare
6c4828a
to
6bc9a36
Compare
ae365d6
to
9e9964b
Compare
550a066
to
d59dead
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
areshand
approved these changes
Jan 9, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
644d149
to
b42b2c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b42b2c3
to
09823fe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grao1991
approved these changes
Jan 14, 2025
@@ -0,0 +1,9 @@ | |||
# Seeds for failure cases proptest has generated in the past. It is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
09823fe
to
5633246
Compare
5633246
to
d21c2a6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
CICD:run-execution-performance-full-test
Run execution performance test (full version)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
struct State
to represent the speculative state, utilizing the LayeredMap / MapLayerState
.Todo: move it further to a separate stage.
Throughput
All single-node-performance cases have seen improvements. See the last commit.
On a 100M account DB and t4d 60 cores machine,
apt-fa-transfer
(with native vm, redoing for aptos vm) saw gain from 32k TPS to 40k TPS:with AptosVM, the same thing saw 24k -> 26.8k TPS improvement.
creating 100 100M accounts DB takes 40 minutes vs 48 minutes from main branch code.
Latency
latency in forge didn't change much:
realistic_env_load_sweep
main: https://github.com/aptos-labs/aptos-core/actions/runs/12696454894
this: https://github.com/aptos-labs/aptos-core/actions/runs/12696477211
realistic_env_workload_sweep
main: https://github.com/aptos-labs/aptos-core/actions/runs/12696466689
this: https://github.com/aptos-labs/aptos-core/actions/runs/12696621130
In theory a block with both heavy execution (but not much reading) and writing to a lot of COLD state items will suffer latency-wise since we don't prefetch the proof anymore and as a result the disk IOs for proof fetching no longer overlap with the execution time, but at our current DB size a warm DB pretty much catches everything (through RocksDB and the filesystem). Explicit caching of hot items is coming so I'm not complicating things by adding pre-fetching back.
How Has This Been Tested?
existing coverage
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?