Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][TESTNET ONLY] Add a testnet only function to allow burning APT #15418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

movekevin
Copy link
Contributor

Description

Add a testnet only function to allow burning APT

How Has This Been Tested?

Unit tests

Key Areas to Review

That this function is only callable on testnet

Type of Change

  • [ x ] New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • [ x ] Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • [ x ] I have read and followed the CONTRIBUTING doc
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ x ] I tested both happy and unhappy path of the functionality
  • [ x ] I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 27, 2024

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 12m 🟩
check-dynamic-deps 2m 🟩
rust-cargo-deny 2m 🟩
general-lints 27s 🟩
semgrep/ci 21s 🟩
file_change_determinator 12s 🟩
permission-check 3s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@gedigi gedigi removed their request for review December 31, 2024 11:13
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant