Enable Collection Owner feature #15420

JohnChangUK · 2024-11-27T20:39:29Z

Description

As part of AIP 95 collections permissions update, enable feature Collection Owner. This enables users to create collections as the collection owner.

How Has This Been Tested?

New functions added and tested.

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-27T20:39:33Z

⏱️ 4h 45m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-unit-tests	48m	🟥 🟩
execution-performance / single-node-performance	25m	🟩
rust-unit-tests	23m	🟩
rust-unit-tests	23m	🟩
rust-unit-tests	23m	🟩
rust-unit-tests	22m	🟩
test-target-determinator	18m	🟩 🟩 🟩 🟩
rust-cargo-deny	10m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-unit-tests	8m	⬜
rust-move-tests	8m	⬜

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

sherry-x · 2024-11-27T21:27:31Z

aptos-move/aptos-release-builder/data/collection-owner.yaml

+proposals:
+  - name: feature_flags
+    metadata:
+      title: ""


fill in a short title for this and description, you can delete the two urls fields

Sounds good, thanks!

trunk-io · 2024-11-27T22:23:38Z

_{View Full Report ↗︎ ⋅ Docs}

aptos-move/aptos-release-builder/data/collection-owner.yaml

sherry-x · 2024-11-27T23:13:30Z

@JohnChangUK you're missing a "name" field, see line 3 here https://github.com/aptos-labs/aptos-core/pull/15266/files

JohnChangUK · 2024-11-28T00:52:50Z

@JohnChangUK you're missing a "name" field, see line 3 here https://github.com/aptos-labs/aptos-core/pull/15266/files

Amended

github-actions · 2024-12-03T00:03:07Z

✅ Forge suite `realistic_env_max_load` success on `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`

two traffics test: inner traffic : committed: 13804.35 txn/s, latency: 2877.77 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3400 ms), latency samples: 5248800
two traffics test : committed: 99.97 txn/s, latency: 2313.78 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 20700 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.459, avg: 1.688", "ConsensusProposalToOrdered: max: 0.331, avg: 0.300", "ConsensusOrderedToCommit: max: 0.375, avg: 0.358", "ConsensusProposalToCommit: max: 0.674, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 2524065 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.52s no progress at version 2524063 (avg 15.52s) [limit 16].
Test Ok

github-actions · 2024-12-03T00:06:31Z

✅ Forge suite `framework_upgrade` success on `afa8d75c467820b7d96bbe13ab0d011c12f8b3a3` ==> `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977 (PR)
Upgrade the nodes to version: a09b55ba3eb3cbd68af0ebd3d0699307b4146977
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1088.45 txn/s, submitted: 1090.93 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2842.77 ms, (p50: 2100 ms, p70: 3000, p90: 5700 ms, p99: 7100 ms), latency samples: 96360
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1155.61 txn/s, submitted: 1158.11 txn/s, failed submission: 2.50 txn/s, expired: 2.50 txn/s, latency: 2673.68 ms, (p50: 1800 ms, p70: 2500, p90: 5900 ms, p99: 7000 ms), latency samples: 101800
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977 passed
Upgrade the remaining nodes to version: a09b55ba3eb3cbd68af0ebd3d0699307b4146977
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1197.45 txn/s, submitted: 1199.68 txn/s, failed submission: 2.23 txn/s, expired: 2.23 txn/s, latency: 2599.84 ms, (p50: 2100 ms, p70: 2700, p90: 4800 ms, p99: 6400 ms), latency samples: 107400
Test Ok

github-actions · 2024-12-03T00:07:26Z

✅ Forge suite `compat` success on `afa8d75c467820b7d96bbe13ab0d011c12f8b3a3` ==> `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 16635.49 txn/s, latency: 2015.73 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 3100 ms), latency samples: 541960
2. Upgrading first Validator to new version: a09b55ba3eb3cbd68af0ebd3d0699307b4146977
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7084.78 txn/s, latency: 3953.57 ms, (p50: 4400 ms, p70: 4600, p90: 4800 ms, p99: 5100 ms), latency samples: 130520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7010.68 txn/s, latency: 4561.27 ms, (p50: 4700 ms, p70: 5000, p90: 6200 ms, p99: 6500 ms), latency samples: 239160
3. Upgrading rest of first batch to new version: a09b55ba3eb3cbd68af0ebd3d0699307b4146977
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6923.77 txn/s, latency: 4112.68 ms, (p50: 4700 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 129800
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6139.85 txn/s, latency: 5146.86 ms, (p50: 5100 ms, p70: 5200, p90: 7300 ms, p99: 7600 ms), latency samples: 235540
4. upgrading second batch to new version: a09b55ba3eb3cbd68af0ebd3d0699307b4146977
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5312.25 txn/s, latency: 5092.39 ms, (p50: 4100 ms, p70: 7700, p90: 8600 ms, p99: 9000 ms), latency samples: 101740
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8923.70 txn/s, latency: 3162.75 ms, (p50: 2400 ms, p70: 4100, p90: 5000 ms, p99: 9800 ms), latency samples: 351460
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977 passed
Test Ok

JohnChangUK requested a review from sherry-x November 27, 2024 20:39

sherry-x reviewed Nov 27, 2024

View reviewed changes

JohnChangUK mentioned this pull request Nov 27, 2024

Enable Collection Owner feature #15419

Closed

22 tasks

JohnChangUK force-pushed the feat/collection-owner branch from 2227b63 to b628d78 Compare November 27, 2024 21:31

sherry-x approved these changes Nov 27, 2024

View reviewed changes

sherry-x added the CICD:run-framework-upgrade-test label Nov 27, 2024

sherry-x requested a review from zekun000 November 27, 2024 22:46

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

graphite-app bot reviewed Nov 27, 2024

View reviewed changes

aptos-move/aptos-release-builder/data/collection-owner.yaml Show resolved Hide resolved

JohnChangUK force-pushed the feat/collection-owner branch from b628d78 to 87f6a99 Compare November 28, 2024 00:44

Enable Collection Owner feature

a09b55b

JohnChangUK force-pushed the feat/collection-owner branch from 87f6a99 to a09b55b Compare November 28, 2024 00:52

This comment has been minimized.

Sign in to view

sherry-x requested a review from igor-aptos December 2, 2024 20:25

igor-aptos approved these changes Dec 2, 2024

View reviewed changes

sherry-x enabled auto-merge (rebase) December 2, 2024 23:31

This comment has been minimized.

Sign in to view

sherry-x merged commit 4ba55f3 into aptos-release-v1.23 Dec 3, 2024
88 checks passed

sherry-x deleted the feat/collection-owner branch December 3, 2024 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Collection Owner feature #15420

Enable Collection Owner feature #15420

JohnChangUK commented Nov 27, 2024

trunk-io bot commented Nov 27, 2024 •

edited

Loading

sherry-x Nov 27, 2024

JohnChangUK Nov 27, 2024

trunk-io bot commented Nov 27, 2024 •

edited

Loading

This comment has been minimized.

This comment was marked as resolved.

sherry-x commented Nov 27, 2024

JohnChangUK commented Nov 28, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

Enable Collection Owner feature #15420

Enable Collection Owner feature #15420

Conversation

JohnChangUK commented Nov 27, 2024

Description

How Has This Been Tested?

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Nov 27, 2024 • edited Loading

sherry-x Nov 27, 2024

Choose a reason for hiding this comment

JohnChangUK Nov 27, 2024

Choose a reason for hiding this comment

trunk-io bot commented Nov 27, 2024 • edited Loading

This comment has been minimized.

This comment was marked as resolved.

sherry-x commented Nov 27, 2024

JohnChangUK commented Nov 28, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2024

✅ Forge suite realistic_env_max_load success on a09b55ba3eb3cbd68af0ebd3d0699307b4146977

github-actions bot commented Dec 3, 2024

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977

github-actions bot commented Dec 3, 2024

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a09b55ba3eb3cbd68af0ebd3d0699307b4146977

trunk-io bot commented Nov 27, 2024 •

edited

Loading

trunk-io bot commented Nov 27, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`

✅ Forge suite `framework_upgrade` success on `afa8d75c467820b7d96bbe13ab0d011c12f8b3a3` ==> `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`

✅ Forge suite `compat` success on `afa8d75c467820b7d96bbe13ab0d011c12f8b3a3` ==> `a09b55ba3eb3cbd68af0ebd3d0699307b4146977`