Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andygolay/no bcs for vecu8 #15428

Closed
wants to merge 305 commits into from
Closed

Andygolay/no bcs for vecu8 #15428

wants to merge 305 commits into from

Conversation

andygolay
Copy link

Description

We shouldn't BCS serialize vec<u8> because it adds a length prefix which changes the value.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

l-monninger and others added 30 commits April 24, 2024 16:04
@l-monninger
fix: playing with deadlock issues.
a1e7cba
@l-monninger
fix: cleanup.
2027a15
@0xmovses
revert nth commit
29555a2
@0xmovses
use with_block_nums
ec57026
@0xmovses
make better assertions
df70fa4
@0xmovses
stop last test flakiness
25bc25e
@l-monninger
fix: make get_transaction_by_hash_inner public.
65f8147
@l-monninger
fix: debugging transaction_by hash issue.
afa2d38
@l-monninger
fix: debugging transaction_by hash issue.
8464283
@l-monninger
fix: debugging transaction_by hash issue.
7f3e0e5
@0xmovses
debugging
d60b3eb
@l-monninger
fix: debugging transaction_by hash issue.
06443b8
@0xmovses
fix bug
723959f
@0xmovses
fmt
6239f63
@mzabaluev
consensus-types: remove request_response
8767d92 
Eliminate the async dependency in consensus-types.
@mzabaluev
cut out tokio from consensus-types
b116b2e 
Stub out the status field in ProofWithData with the vector that's
evenutally supposed to be retrieved, until we figure out if we need
the field and the whole structure at all.
@mzabaluev
aptos-vm: cut out use of futures
2c3f7f0
@mzabaluev
Cut out aptos-consensus and dependent crates
61bd4ee 
aptos-consensus had code that provided consensus-types data
in asynchronous sends. Since we are not likely to need this crate
anyway, cut it out of the workspace. Also remove any dependent crates.
@mzabaluev
aptos-network: fix up noise imports in tests
224dd28
@mzabaluev
experimiental/runtimes: remove tokio dep
8b25298
@mzabaluev
aptos-dkg: relax dep on aptos-experimental-runtimes
8319a2b 
It's only used in test code, move it to dev-dependencies
@mzabaluev
aptos-logger: cut out async logging
bd3e72f
@l-monninger
Merge pull request #10 from movementlabsxyz/mikhail/trim-aptos-logger
e62577b 
ENG-251 aptos-logger: cut out async logging
@0xmovses
Merge branch 'monza' into 0xmovses/ENG-206-implement-block-reversion
8bf8f2a
@0xmovses
add reversion to Writer trait, enable epoch reversion
27c8c96
@0xmovses
add new commit reversion method
7d807dc
@l-monninger
Merge pull request #7 from movementlabsxyz/mikhail/de-async
187ecc3 
ENG-180: Cut out async dependencies from consensus-types and async-vm
@l-monninger
Merge pull request #6 from movementlabsxyz/0xmovses/ENG-206-implement…
53c6948 
…-block-reversion

ENG-206 Implement Block Reversion
chore: remove logging.
02d3236
fix: trying miscellaneous state view id.
99cf0d3
Primata and others added 27 commits November 19, 2024 23:26
@Primata
add native bridge
e8b8ca7
@Primata
readd atomic bridge
8f57889
@andygolay
fix: compiles but multiple unit tests fail
ea9ba3b
@andygolay
fix: test_complete_bridge_transfer and test_complete_bridge_transfer_…
38ca862 
…by_sender pass
@andygolay
test: add set_nonce_to_bridge_transfer_id into initiate_bridge_transfer
dfa049f
@andygolay
feat: all move unit tests pass, initiate happy path test added
92f5dda
@andygolay
fix: remove conflicting Nonce struct from native_bridge_store
8739e2d
@andygolay
fix: restore atomic_bridge.move and e2e tests from movement branch
e05e519
@andygolay
feat: add Rust E2E test test_native_bridge_initiate and initiate nati…
67d6b30 
…ve bridge in genesis
@andygolay
feat: check for existing incoming nonce and add incoming nonce to tab…
4e6eb34 
…le in complete_bridge_transfer
@Primata
tiny changes
ff34661
@Primata
add native bridge.spec
97a965c
@andygolay
update: change operator to relayer, comment out spec for now
4b0d752
@andygolay
fix: map nonce to details rather than to bridge transfer ID
3afb59e
@andygolay
clean: remove more unneeded code from the atomic_bridge model
99e244d
@andygolay
clean: more cleanup of unneeded functions and code
21f6273
@andygolay
feat: updated OutboundTransfer struct
5b92fc3
@andygolay
feat: increase spec converage (compiles but doesn't pass aptos move p…
3b91758 
…rove), add nonzero nonce check
@andygolay
clean: integrate more review feedback, clean up move warnings
6d2f6b2
@andygolay
rename: incoming -> inbound
fa9f056
@andygolay @Primata
Update aptos-move/framework/aptos-framework/sources/native_bridge.move
ed39adb 
Co-authored-by: Primata <[email protected]>
@andygolay
Merge pull request #100 from movementlabsxyz/andygolay/simplified-bridge
111a554 
Framework Move modules and spec for Trusted Relayer Native Bridge
@l-monninger
feat: sponsored transactions.
e7c3e0a
@l-monninger
fix: tests.
a965405
@l-monninger
fix: revert.
69feea3
@l-monninger
Merge pull request #103 from movementlabsxyz/l-monninger/revert
beafb1f 
fix: revert.
@andygolay
initial commit
06cab6d
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 29, 2024 •
edited
Loading

⏱️ 6s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 4s 🟥 
permission-check 2s 🟥 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@andygolay andygolay closed this Nov 29, 2024
@andygolay
Copy link
Author

wrong target repo, apologies 👉 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinush alinush Awaiting requested review from alinush alinush will be requested when the pull request is marked ready for review alinush is a code owner

@heliuchuan heliuchuan Awaiting requested review from heliuchuan heliuchuan will be requested when the pull request is marked ready for review heliuchuan is a code owner

@rex1fernando rex1fernando Awaiting requested review from rex1fernando rex1fernando will be requested when the pull request is marked ready for review rex1fernando is a code owner

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind will be requested when the pull request is marked ready for review JoshLind is a code owner

@bchocho bchocho Awaiting requested review from bchocho bchocho will be requested when the pull request is marked ready for review bchocho is a code owner

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario will be requested when the pull request is marked ready for review gregnazario is a code owner

@banool banool Awaiting requested review from banool banool will be requested when the pull request is marked ready for review banool is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash will be requested when the pull request is marked ready for review gelash is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun ibalajiarun will be requested when the pull request is marked ready for review ibalajiarun is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@junkil-park junkil-park Awaiting requested review from junkil-park junkil-park will be requested when the pull request is marked ready for review junkil-park is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov georgemitenkov will be requested when the pull request is marked ready for review georgemitenkov is a code owner

@0xmaayan 0xmaayan Awaiting requested review from 0xmaayan 0xmaayan will be requested when the pull request is marked ready for review 0xmaayan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andygolay @l-monninger @0xmovses @mzabaluev @andyjsbell @musitdev @Primata