Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump to 4.6.0 #15429

Merged
merged 2 commits into from
Nov 30, 2024
Merged

[cli] Bump to 4.6.0 #15429

merged 2 commits into from
Nov 30, 2024

Conversation

0xjunha
Copy link
Contributor

@0xjunha 0xjunha commented Nov 29, 2024

Description

Bump CLI version to 4.6.0

  • Add --node-api-key flag to aptos move replay to allow for querying the fullnode with an API key.
  • Add --chunk-size flag to allow configuring chunk size for chunked publish mode.
  • Lower the default chunk size for chunked publish mode (CHUNK_SIZE_IN_BYTES) from 60,000 to 55,000.

How Has This Been Tested?

n/a

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

* Add `--node-api-key` flag to `aptos move replay` to allow for querying the fullnode with an API key.
* Add `--chunk-size` flag to allow configuring chunk size for chunked publish mode.
* Lower the default chunk size for chunked publish mode (`CHUNK_SIZE_IN_BYTES`) from 60,000 to 55,000.
Copy link

trunk-io bot commented Nov 29, 2024

⏱️ 1h 36m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 5m 🟩🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩🟩
rust-smoke-tests 2m 🟥
rust-doc-tests 1m 🟥🟥
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@0xjunha 0xjunha enabled auto-merge (squash) November 29, 2024 19:05

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81 (PR)
Upgrade the nodes to version: befbbead6a4d8e68038f93145bb7f2534b456d81
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1232.25 txn/s, submitted: 1234.75 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2432.23 ms, (p50: 2100 ms, p70: 2500, p90: 4200 ms, p99: 5400 ms), latency samples: 108720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1339.69 txn/s, submitted: 1342.44 txn/s, failed submission: 2.74 txn/s, expired: 2.74 txn/s, latency: 2208.85 ms, (p50: 2000 ms, p70: 2100, p90: 3600 ms, p99: 5400 ms), latency samples: 117200
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81 passed
Upgrade the remaining nodes to version: befbbead6a4d8e68038f93145bb7f2534b456d81
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.99 txn/s, submitted: 1368.77 txn/s, failed submission: 3.78 txn/s, expired: 3.78 txn/s, latency: 2202.84 ms, (p50: 2000 ms, p70: 2100, p90: 3500 ms, p99: 4900 ms), latency samples: 122780
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14327.82 txn/s, latency: 2366.38 ms, (p50: 2000 ms, p70: 2100, p90: 3600 ms, p99: 8100 ms), latency samples: 463940
2. Upgrading first Validator to new version: befbbead6a4d8e68038f93145bb7f2534b456d81
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7165.10 txn/s, latency: 3928.10 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 5000 ms), latency samples: 131100
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6443.71 txn/s, latency: 5038.82 ms, (p50: 5100 ms, p70: 5200, p90: 7100 ms, p99: 7300 ms), latency samples: 226700
3. Upgrading rest of first batch to new version: befbbead6a4d8e68038f93145bb7f2534b456d81
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7315.68 txn/s, latency: 3892.32 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 136000
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6785.35 txn/s, latency: 4684.94 ms, (p50: 4700 ms, p70: 4800, p90: 6700 ms, p99: 7000 ms), latency samples: 253760
4. upgrading second batch to new version: befbbead6a4d8e68038f93145bb7f2534b456d81
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 2533.02 txn/s, submitted: 2533.19 txn/s, expired: 0.17 txn/s, latency: 3071.35 ms, (p50: 3000 ms, p70: 3700, p90: 4500 ms, p99: 4800 ms), latency samples: 163249
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9502.10 txn/s, latency: 3042.70 ms, (p50: 2800 ms, p70: 3300, p90: 3700 ms, p99: 5500 ms), latency samples: 352320
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> befbbead6a4d8e68038f93145bb7f2534b456d81 passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on befbbead6a4d8e68038f93145bb7f2534b456d81

two traffics test: inner traffic : committed: 14136.69 txn/s, latency: 2812.20 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5375080
two traffics test : committed: 100.03 txn/s, latency: 2385.73 ms, (p50: 2000 ms, p70: 2100, p90: 2200 ms, p99: 18200 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.102, avg: 1.210", "ConsensusProposalToOrdered: max: 0.310, avg: 0.292", "ConsensusOrderedToCommit: max: 0.377, avg: 0.367", "ConsensusProposalToCommit: max: 0.670, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.05s no progress at version 2278681 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.85s no progress at version 2278679 (avg 15.85s) [limit 16].
Test Ok

@0xjunha 0xjunha merged commit 311de72 into aptos-labs:main Nov 30, 2024
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants