Continued re-design of paranoid mode (now called Runtime Type Check) #15437
+77
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 23m total CI duration on this PR
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -29,6 +29,12 @@ pub(crate) trait RuntimeTypeCheck { | |||
| ty_cache: &mut FrameTypeCache, | |||
| instruction: &Bytecode, | |||
| ) -> PartialVMResult<()>; | |||
|
|
|||
| /// Pranoid check that operand and type stacks have the same size | |||
There was a problem hiding this comment.
Typo in docstring: Pranoid -> Paranoid. This maintains consistency with terminology used throughout the codebase.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
georgemitenkov
approved these changes
Dec 2, 2024
| @@ -29,6 +29,12 @@ pub(crate) trait RuntimeTypeCheck { | |||
| ty_cache: &mut FrameTypeCache, | |||
| instruction: &Bytecode, | |||
| ) -> PartialVMResult<()>; | |||
|
|
|||
| /// Paranoid check that operand and type stacks have the same size | |||
There was a problem hiding this comment.
nit: .s in the end of docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving towards static implementation of the paranoid mode switch, allowing for compiler optimizations.
How Has This Been Tested?
Existing tests
Key Areas to Review
Make sure the end to end functionality is NOT changed.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist