[crypto] Refactor AuthenticationKey #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostWalker562
force-pushed
the
main
branch
5 times, most recently
from
0662c8d to
6070e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the following concepts:
All PublicKeys are not separated by UnifiedPublicKey or LegacyPublicKey but are now considered a "PublicKey". It is the responsibility of the AccountAuthenticator to runtime check whether they support the key.
For example,
SingleKeyAccountcan only support a "signing key" (Keyless, Ed25519, Secp256k1) and not a unified PublicKey (MultiKey). It will check this condition in the constructor.Serialization of AnyPublicKey and AnySignature is the responsibility of the Accounts instead of the PublicKeys.
Authentication keys are moved to the account versus the public key. This prevents confusion when users derive two different accounts with one private key (SingleKey account vs Ed25519 account).
Test Plan
Related Links
N/A