More crypto updates #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a bunch of TODOs, and uses the single serializers everywhere possible to clean up duplicate code.
This cleans up all the crypto to be ordered in the same standard order as well as add most support for keys. They do need some tests added, but it is much more standardized now.
brianolson
approved these changes
Jun 4, 2024
| PublicKey() PublicKey | ||
|
|
||
| // Signature return the signature bytes | ||
| // Signature is a typed signature that can be verified by the public key. It must be a valid on-chain representation | ||
| // // and cannot be something like Secp256k1Signature on its own. |
Yeah, I expect to test everything before I make it 1.0, but I will stabilize in a release before then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reworks TransactionAuthenticators to support Fee Payer, and other signers.
It's important to rework, because otherwise, it only supports single sender on Ed25519.
Test Plan
Secp256k1 does not work properly when tested on-chain, but Ed25519 works with single sender and the legacy format. MultiEd25519 and MultiKey were tested for cryptography, but not for on-chain representation. That will need to be tested in a future release.
Related Links